New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct XMLns for gml? #330
Comments
Hi, @SimonBin thank you for your question. In the GeoSPARQL standard, we only define literal types, so we only define the type geo:gmlLiteral type in your case. |
after looking into it a bit more closely, I actually have reason to believe it is wrong, because |
Indeed you are right, gml:pos is not defined in http://www.opengis.net/ont/gml |
Touching standard XML namespaces in an attempt to somehow link from the XML world to the RDF one seems like a bad idea as it breaks all tooling relying on those namespaces. Strictly speaking, if an XML document uses a different namespace for GML then its no longer GML. If I used It is the GML/XML spec that would have to explicitly allow for using If I understand your last sentence correctly, you agree that all implementations (not just jena) should support the conventional GML namespaces - right? |
Yes, correct, this is the way I see it. GML literals encoded in GML 3.2 should use the GML 3.2 namespace, GML 2.0 literals the GML 2.0 namespace and so on... |
@situx Right. GML literals should use the namespace for their GML version. |
Great! Then we have a linked pull request now to fix this issue |
The GeoSPARQL standard references OGC07-036 here: https://github.com/opengeospatial/ogc-geosparql/blob/master/1.1/spec/11-Part-08.adoc#geography-markup-language-serializationgml
which defines
http://www.opengis.net/gml/3.2
as the XML namespace of GML in section 5.1This example file from the repo:
ogc-geosparql/1.1/moreton-island.gml
Lines 41 to 42 in 7ac4209
(currently removed)
likewise uses this namespace.
In the sole example on
ogc-geosparql/1.1/spec/11-Part-08.adoc
Lines 442 to 447 in dc9cb57
however, a different namespace (the RDF Ontology namespace
http://www.opengis.net/ont/gml
) is used.This creates interoperability problems when consuming a GML file from WFS and trying to load it into a gmlLiteral, as the XML tags do not match any more. Is this a bug/bad example in the standard? Or are we supposed to massage GML with
sed
to alter the XML namespaces?Currently, Apache Jena hardcodes the NS from the example:
https://github.com/apache/jena/blob/231624d00188f58da6c15fcf5f940f0448111d02/jena-geosparql/src/main/java/org/apache/jena/geosparql/implementation/parsers/gml/GMLReader.java#L67
and is thus unable to correctly parse a GML geometry from a regular GML document
This also touches upon #144
The text was updated successfully, but these errors were encountered: