Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CQL BNF does not support double quoted identifiers #332

Closed
aaime opened this issue Feb 18, 2020 · 4 comments · Fixed by #463
Closed

CQL BNF does not support double quoted identifiers #332

aaime opened this issue Feb 18, 2020 · 4 comments · Fixed by #463

Comments

@aaime
Copy link
Contributor

aaime commented Feb 18, 2020

From the catalog 3.0 BNF:

<regular identifier> ::= <identifier body>
                     | <double quote> {unicode_character} <double quote>[16]

The [16] is a footnote with the following description:

This change is inspired in SQL in order to accept local character sets as property name. Moreover, it resolves the clash problem between cql keywords and property names.

GeoServer CQL implementation supports double quoted identifiers for this very reason, avoid clashes and deal with special characters that might have been used a part of an identifier (relationa databases seems to allow pretty much anything in column names, as long as the name is double quoted).

@cportele
Copy link
Member

cportele commented Aug 3, 2020

2020-08-03: @pvretano will review this and we will get back to it afterwards. The question is whether we want to support such identifiers in CQL. This has an impact on queryables and their representation, too. Are we making life of everyone just more complex? We probably need more feedback from implementers, perhaps keep this open in the public review and explicitly ask for feedback.

@cportele
Copy link
Member

cportele commented Nov 9, 2020

Meeting 2020-11-09: @pvretano has updated the text to support double quotes and this will be pushed soon.

@cportele cportele moved this from Waiting for input to To be drafted in Features Part 3: Filtering / Common Query Language (CQL2) Nov 9, 2020
@cportele
Copy link
Member

Meeting 2020-11-23: It has been added to the BNF (or more correctly the text encoding), but it is unclear if/how to add it to the JSON encoding. This makes sense and we will leave it at that and wait for any comments.

@pvretano pvretano linked a pull request Dec 2, 2020 that will close this issue
Features Part 3: Filtering / Common Query Language (CQL2) automation moved this from In review to Done Dec 7, 2020
@cportele
Copy link
Member

cportele commented Dec 7, 2020

Reopen for review in SWG meeting on 2020-12-07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

3 participants