Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Listing of all applicable HTTP Status Codes #45

Closed
cmheazel opened this issue Feb 26, 2018 · 7 comments
Closed

Listing of all applicable HTTP Status Codes #45

cmheazel opened this issue Feb 26, 2018 · 7 comments
Assignees
Labels
OGC API: Common Issue related to general resources or requirements (see #190) Part 1: Core Issue related to Part 1 - Core progress: pull request available

Comments

@cmheazel
Copy link
Contributor

Requirement 38 - I question if this is feasible. Implementers should not be required to research and describe every status code which may be returned by the HTTP protocol. Many of these are artifacts of the network topology and HTTP protocol itself. It is feasible for implemeters to describe any status codes produced by their service which are not standard HTTP codes. I suspect that is the intent of the requirement. But without a specific definition of "service" as being the software logic accessible through the Base URL, this requirement is ambiguous.

@cportele cportele added progress: ready for discussion Part 1: Core Issue related to Part 1 - Core labels Feb 27, 2018
@cportele
Copy link
Member

cportele commented Feb 27, 2018

By now this is no longer requirement 38. I think this refers to requirement /req/oas30/exceptions-codes (https://rawgit.com/opengeospatial/WFS_FES/master/docs/17-069.html#exceptions).

I understand the comment and it would be good to have a good understanding what the general practice and expectations are in the OpenAPI community.

PS: To exclude errors raised in the transport between the server and the client by using the wording "error situations that originate from the server".

@cportele cportele added this to the Part 1, Second Draft Release milestone Aug 8, 2018
@akuckartz
Copy link

Such a listing of status codes should not be normative because they are specified in the HTTP specification(s). See https://tools.ietf.org/html/rfc7231#section-6

@cportele cportele added the OGC API: Common Issue related to general resources or requirements (see #190) label Mar 5, 2019
@cportele
Copy link
Member

cportele commented May 6, 2019

06-MAY-2019 Conference calls: Make it a recommendation. We ended up with: "The API definition SHOULD cover the HTTP error codes for each operation for error situations that originate from the API implementation. Note that error codes originating from the protocol level will not be included in the API definition, but still need to be handled by clients. This is implicit in the requirement for HTTP compliance." Chuck will make a proposal.

@akuckartz
Copy link

This seems to imply that "API implementation" != "protocol level"

I doubt that such a difference exists or should exist. But I will wait for the proposal.

@cportele
Copy link
Member

cportele commented May 8, 2019

@akuckartz - Yes, the notes were a bit brief. "Protocol level" here refers to anything between the API implementation and the client. For example a 504 created by a proxy. If the API implementation will never return a 504 for an operation this status code does not belong into the API definition of that operation, but clients still have to be prepared to receive a 504 (or any other undocumented status code). However, if the API implementation may return a 500, this should be documented in the API definition.

@cmheazel
Copy link
Contributor Author

cmheazel commented Jun 3, 2019

Please review and comment on pull request #223

@cmheazel
Copy link
Contributor Author

Pull request has been updated. Added a paragraph on how the status codes should be advertised in the API Description Document.

Features Part 1: Core automation moved this from In Review to Done Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OGC API: Common Issue related to general resources or requirements (see #190) Part 1: Core Issue related to Part 1 - Core progress: pull request available
Projects
Development

No branches or pull requests

3 participants