Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove replacing of ' ' with '+' in SPCP SAML artifact #1322

Closed
mantariksh opened this issue Mar 9, 2021 · 0 comments · Fixed by #1325
Closed

Remove replacing of ' ' with '+' in SPCP SAML artifact #1322

mantariksh opened this issue Mar 9, 2021 · 0 comments · Fixed by #1325
Assignees
@mantariksh
Labels
P2 planned for next 1-2 months

Comments

@mantariksh
Copy link
Contributor

We have legacy code to replace all spaces in the SAML artifact returned by SingPass/CorpPass with pluses, but this is no longer necessary as the SAML artifact is URL-encoded.
@mantariksh mantariksh self-assigned this Mar 9, 2021
@mantariksh mantariksh mentioned this issue Mar 9, 2021
Merged
@liangyuanruo liangyuanruo added the P2 planned for next 1-2 months label Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mantariksh mantariksh

Labels
P2 planned for next 1-2 months
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: stop replacing spaces in SAML artifact opengovsg/FormSG
2 participants
@liangyuanruo @mantariksh