Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Test] More E2E tests #2176

Merged
merged 4 commits into from Mar 15, 2023
Merged

[Test] More E2E tests #2176

merged 4 commits into from Mar 15, 2023

Conversation

oversparkling
Copy link
Contributor

Problem

What problem are you trying to solve? What issue does this close?

Closes [insert issue #]

Solution

How did you solve the problem?

Features:

  • Details ...

Improvements:

  • Details ...

Bug Fixes:

  • Details ...

Before & After Screenshots

BEFORE:
[insert screenshot here]

AFTER:
[insert screenshot here]

Tests

What tests should be run to confirm functionality?

Deploy Notes

Notes regarding deployment of the contained body of work. These should note any
new dependencies, new scripts, etc.

New environment variables:

  • env var : env var details

New scripts:

  • script : script details

New dependencies:

  • dependency : dependency details

New dev dependencies:

  • dependency : dependency details

@oversparkling oversparkling changed the title [Test [Test] More E2E tests Mar 14, 2023
@oversparkling oversparkling linked an issue Mar 14, 2023 that may be closed by this pull request
More E2E tests #2172
Open
7 tasks
@gweiying gweiying changed the base branch from develop to test/e2e-test March 15, 2023 03:08
@gweiying
Copy link
Contributor

gweiying commented Mar 15, 2023 •
edited

Noting that the above tests addresses the following test cases:

Redirection

  • It should redirect to the long url when short url is active
  • It should redirect to a 404 page when short url is inactive

Drawer, Editing and Toaster logic

  • It should redirect to the amended file immediately when the file is replaced (any caching for that short url is cleared)

gweiying
gweiying approved these changes Mar 15, 2023
View reviewed changes
Copy link
Contributor

@gweiying gweiying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@gweiying gweiying marked this pull request as ready for review March 15, 2023 03:44
@oversparkling oversparkling merged commit 4a8461e into test/e2e-test Mar 15, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gweiying gweiying gweiying approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

More E2E tests
2 participants
@oversparkling @gweiying