feat: implement email domain validation with unit tests #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karrui
reviewed
Aug 24, 2020
There was a problem hiding this comment.
Some interim comments till the backend validation is also performed; feel free to ping me on Slack anytime for queries.
If possible, try to also add tests for the email field schema in tests/unit/backend/models/form_fields.schema.spec.ts or even create a new test file tests/unit/backend/models/formFields/email.schema.spec.ts!
You can refer to createAndReturnFormField method in form_fields test file to retrieve a single form field with the email type to test with.
src/public/modules/forms/admin/controllers/edit-fields-modal.client.controller.js
Outdated
Show resolved
Hide resolved
src/public/modules/forms/admin/controllers/edit-fields-modal.client.controller.js
Outdated
Show resolved
Hide resolved
src/public/modules/forms/base/components/field-email.client.component.js
Outdated
Show resolved
Hide resolved
tests/unit/backend/utils/field-validation/email-validation.spec.js
Outdated
Show resolved
Hide resolved
…es from controllers
…ltip for email domain fields
|
I'll take a look at why the tests are failing on Monday and advise you on next steps :D |
…ains placeholder and migrate email validation tests
…e below the field and prevent error when textarea value is empty (cannot call .split on empty string)
… exist on type 'IEmailFieldSchema'.
karrui
requested changes
Sep 24, 2020
src/public/modules/forms/admin/controllers/edit-fields-modal.client.controller.js
Outdated
Show resolved
Hide resolved
src/public/modules/forms/admin/views/edit-fields.client.modal.html
Outdated
Show resolved
Hide resolved
tests/unit/backend/utils/field-validation/email-validation.spec.ts
Outdated
Show resolved
Hide resolved
…rt require and add a warning to prevent changes to onclick=""
…ously extend types 'IEmailField' and 'IFieldSchema'.
… allowedEmailDomainsFromText
This was referenced Sep 29, 2020
Merged
jia1
added
contribute
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This pull request enables forms to have email domain validation for the email field.
Closes #54
Before & After Screenshots
BEFORE:
AFTER:
