Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Xiaomi Mi IO] Improve robot vacuum cleaning map to ease UI integration #10112

Closed
curlyel opened this issue Feb 9, 2021 · 2 comments · Fixed by #11110
Closed

[Xiaomi Mi IO] Improve robot vacuum cleaning map to ease UI integration #10112

curlyel opened this issue Feb 9, 2021 · 2 comments · Fixed by #11110
Labels
enhancement An enhancement or new feature for an existing add-on

Comments

@curlyel
Copy link

curlyel commented Feb 9, 2021

Current cleaning map implementation

The current cleaning map fills the unused area beyond the outline of the scanned cleaning area with a fixed blue color and a watermark:

image

While the map is for sure an interesting element to be shown in UI's of openHAB, I see three points complicating the intergration:

  1. The blue color does not subordinate well to the surrounding design
  2. The blue area is too wide/to dominant
  3. The openHAB watermark conflicts with neigboring or overlaid UI elements

These reasons lead to some tricky CSS workarounds to get it almost nicely integrated (notice the overlaid labels and icons to "use" the dominant blue area)
E.g.:

image

Improvement proposal

Currently I see the following options to ease the integration of the map into UI's

  • replace the blue (background) color by transparent
  • crop the image to the used area
  • omit the watermark imprint

Your Environment

  • openhAB 3.1M1
  • Roborock S5max

references on the openHAB community forum:
https://community.openhab.org/t/xiaomi-robot-vacuum-binding/31317/1797
https://community.openhab.org/t/xiaomi-robot-vacuum-binding/31317/1337

@marcelrv pointed (here: https://community.openhab.org/t/xiaomi-robot-vacuum-binding/31317/1725 ) to the relevant piece of code already:

It is not something that is selectable in the binding.
You can recompile it with your preferred colors. Change them here https://github.com/openhab/openhab-addons/blob/main/bundles/org.openhab.binding.miio/src/main/java/org/openhab/binding/miio/internal/robot/RRMapDraw.java#L64-L91 4

@curlyel curlyel added the enhancement An enhancement or new feature for an existing add-on label Feb 9, 2021
@openhab-bot
Copy link
Collaborator

This issue has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/xiaomi-robot-vacuum-binding/31317/1802

@marcelrv
Copy link
Contributor

like your sample widget!

The current 'blue style' is indeed borrowed from the v1 maps which was much less feature rich. It would be good to make the coloring configurable so it can suit everyones wishes.
If I make the style configurable, I'll also make the the text/logo optional

The cropping is indeed desirable.. I marked it in my 'roadmap' as a feature I would like #7276 but it is bit beyond my programming skills. (the whole grapical thing was a first timer for me)
At the moment it just shows the picture as it is provided by the cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants