Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[androidtv] Expand i18n messaging #15144

Closed
morph166955 opened this issue Jun 27, 2023 · 2 comments · Fixed by #15184
Closed

[androidtv] Expand i18n messaging #15144

morph166955 opened this issue Jun 27, 2023 · 2 comments · Fixed by #15184
Assignees
@morph166955
Labels
enhancement An enhancement or new feature for an existing add-on

Comments

@morph166955
Copy link
Contributor

As requested in #14282 by @jlaur -

Expand the i18n messaging by having each ConnectionManager do i18n lookups.

Currently, in AndroidTVHandler at checkThingStatus(), the status of each is concatinated (for example "GoogleTV: ONLINE | ShieldTV: Connecting..."). Adding parameter substitution in the ConnectionManagers should allow for better i18n handling across the binding.
@morph166955 morph166955 added the enhancement An enhancement or new feature for an existing add-on label Jun 27, 2023
@morph166955 morph166955 self-assigned this Jun 27, 2023
@morph166955
Copy link
Contributor Author

Example #12949

@openhab-bot
Copy link
Collaborator

This issue has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/androidtv-binding-3-2-0-4-0-0/142203/471

@morph166955 morph166955 mentioned this issue Jul 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@morph166955 morph166955

Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[androidtv] Add additional i18n support to ConnectionManagers morph166955/openhab-addons
2 participants
@openhab-bot @morph166955