[androidtv] ShieldTV Protocol Exception when App Updates

[morph166955]

When an app updates, ShieldTV sends the following (example) which causes an exception. This should be handled differently.

2023-09-19 15:24:11.071 [TRACE] [tocol.shieldtv.ShieldTVMessageParser] - livingroom - Received ShieldTV message from: SHIELD - Message: 08f107122a080512260a24636f6d2e676f6f676c652e616e64726f69642e74762e72656d6f74652e7365727669636518f107
2023-09-19 15:24:11.071 [INFO ] [tocol.shieldtv.ShieldTVMessageParser] - livingroom - Individual App Update - Please Report This: 08f107122a080512260a24636f6d2e676f6f676c652e616e64726f69642e74762e72656d6f74652e7365727669636518f107
2023-09-19 15:24:12.152 [TRACE] [tocol.shieldtv.ShieldTVMessageParser] - livingroom - Received ShieldTV message from: SHIELD - Message: 08f10712870108041282010a24636f6d2e676f6f676c652e616e64726f69642e74762e72656d6f74652e736572766963651219416e64726f69642054562052656d6f74652053657276696365223d687474703a2f2f31302e3235352e302e32303a33363931372f636f6d2e676f6f676c652e616e64726f69642e74762e72656d6f74652e73657276696365280118f107
2023-09-19 15:24:12.152 [WARN ] [tocol.shieldtv.ShieldTVMessageParser] - livingroom - Message Parser Exception on 08f10712870108041282010a24636f6d2e676f6f676c652e616e64726f69642e74762e72656d6f74652e736572766963651219416e64726f69642054562052656d6f74652053657276696365223d687474703a2f2f31302e3235352e302e32303a33363931372f636f6d2e676f6f676c652e616e64726f69642e74762e72656d6f74652e73657276696365280118f107
2023-09-19 15:24:12.153 [WARN ] [tocol.shieldtv.ShieldTVMessageParser] - livingroom - Message Parser Caught Exception

[morph166955]

Individual Update:

08f10712 2a 08 05 12 26 0a LEN app.name 18f107

Examples:

08f10712 2008 05 121c0a 1a636f6d2e676f6f676c652e616e64726f69642e77656276696577 18f107
08f10712 2808 05 12240a 22636f6d2e676f6f676c652e616e64726f69642e617070732e6d656469617368656c6c 18f107
08f10712 2108 05 121d0a 1b636f6d2e676f6f676c652e616e64726f69642e6261636b64726f70 18f107
08f10712 2a08 05 12260a 24636f6d2e676f6f676c652e616e64726f69642e696e7075746d6574686f642e6c6174696e 18f107
08f10712 2008 05 121c0a 1a636f6d2e676f6f676c652e616e64726f69642e6b61746e697373 18f107
08f10712 2d08 05 12290a 27636f6d2e676f6f676c652e616e64726f69642e74756e677374656e2e7365747570777261697468 18f107
08f10712 2808 05 12240a 22636f6d2e676f6f676c652e616e64726f69642e6d617276696e2e74616c6b6261636b 18f107
08f10712 1b08 05 12170a 15636f6d2e676f6f676c652e616e64726f69642e7476 18f107

Individual Update (Longer):
08f10712 8701 08 04 12 8201 0a LEN app.name 12 LEN app.real.name 22 LEN URL 28 01 30 01 18f107
08f10712 6d 08 06 12 69 0a LEN app.name 12 LEN app.real.name 18 02 22 LEN URL 28 01 30 01 18f107

Examples:

08f10712 8701 08 04 12 8201 0a 24 636f6d2e676f6f676c652e616e64726f69642e74762e72656d6f74652e73657276696365 12 19 416e64726f69642054562052656d6f74652053657276696365 22 3d 687474703a2f2f31302e3235352e302e32303a33363931372f636f6d2e676f6f676c652e616e64726f69642e74762e72656d6f74652e73657276696365 28 01 18f107
08f10712 5e 08 04 12 5a 0a 15 636f6d2e676f6f676c652e616e64726f69642e7476 12 0d 4c697665204368616e6e656c73 22 2e 687474703a2f2f31302e3235352e302e32303a33383237392f636f6d2e676f6f676c652e616e64726f69642e7476 28 01 30 01 18f107
08f10712 6b 08 06 12 67 0a 19 636f6d2e676f6f676c652e616e64726f69642e766964656f73 12 10 506c6179204d6f766965732026205456 18 08 22 32 687474703a2f2f31302e3235352e302e32303a33353635352f636f6d2e676f6f676c652e616e64726f69642e766964656f73 28 01 30 01 18f107
08f10712 6d 08 06 12 69 0a 1d 636f6d2e676f6f676c652e616e64726f69642e706c61792e67616d6573 12 0a 506c61792047616d6573 18 02 22 36 687474703a2f2f31302e3235352e302e32303a34323634332f636f6d2e676f6f676c652e616e64726f69642e706c61792e67616d6573 28 01 30 01 18f107

Full Update:
08f10712 d81f 08 01 12 d31f 0a 54 0a LEN app.name 12 LEN app.real.name 22 LEN URL 28 01 30 01 0a 65 0a LEN

The HEX after 08f10712 seems to represent a little endian length of the overall packet with 08 as a delimiter.

Then a set of XX 12 where XX may represent an update type and 12 the ending delimiter.

Then another length which is exactly 5 shorter than the length before followed by a 0a delimiter.

In the full update there is then another number followed by 0a. In the individual update this is the length of the app name.

Then LEN app.name 12 LEN app.real.name 22 LEN URL 28 01 30 01

All then end 18f107.

[lsiepel]

This issue has the regression label. Usually this label is added if this issue was introduced by a previous (recent) PR. Could you link that PR? Or remove the regression label?

[morph166955]

My understanding was that regression kept it out of the release notes if it was something that was broken and missed earlier. I can remove the tags on both if this was improperly used.

[lsiepel]

You are right, but the release notes are only made of the PR's not the issues. For the issues all this tag does, is just for searching/catagorizing.

And i would also think it is fine to add this to the release notes. As these two issues do solve a bug that was not introduced in a recent PR, but just something that was allready broken/never fixed before.

[morph166955]

Regression removed.

[openhab-bot]

This issue has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/androidtv-binding-3-2-0-4-2-0/142203/1