Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pushbullet] Backward 1.x compatibility issue with broadcast notifications #5982

Closed
jsetton opened this issue Aug 26, 2019 · 1 comment
Closed
Assignees

Comments

@jsetton
Copy link
Contributor

jsetton commented Aug 26, 2019

Expected Behavior

In the Pushbullet 1.x binding, notifications could be broadcast to all the devices of a given account by calling the action method with a title and message.

Current Behavior

While testing the new binding introduced in #5668, this functionality isn't working anymore. It seems that now a recipient is always needed. So, when calling the action with two parameters, the recipient would be set with the title causing the notification being sent out to miss that information.

Steps to Reproduce

Rule

val actions = getActions("pushbullet", "pushbullet:bot:default")
actions.sendPushbulletNote("Test Notification", "Test 2.x")

Logs

2019-08-22 17:54:12.365 [DEBUG] [t.internal.handler.PushbulletHandler] - sendPush is called for
2019-08-22 17:54:12.365 [DEBUG] [t.internal.handler.PushbulletHandler] - Thing org.eclipse.smarthome.core.thing.internal.ThingImpl@6f24a793
2019-08-22 17:54:12.366 [DEBUG] [t.internal.handler.PushbulletHandler] - Thing Label: 'Pushbullet Default Bot'
2019-08-22 17:54:12.366 [DEBUG] [t.internal.handler.PushbulletHandler] - CFG org.openhab.binding.pushbullet.internal.PushbulletConfiguration@176fd872
2019-08-22 17:54:12.366 [DEBUG] [t.internal.handler.PushbulletHandler] - Headers: {Content-Type=application/json, User-Agent=openHAB / Pushbullet binding 2.5.0.201908182253, Access-Token=xxxxxxxxxx}
2019-08-22 17:54:12.366 [DEBUG] [t.internal.handler.PushbulletHandler] - Recipient is 'Test Notification'
2019-08-22 17:54:12.367 [DEBUG] [t.internal.handler.PushbulletHandler] - Title is     ''
2019-08-22 17:54:12.367 [DEBUG] [t.internal.handler.PushbulletHandler] - Message is   'Test 2.x'
2019-08-22 17:54:12.367 [WARN ] [t.internal.handler.PushbulletHandler] - Invalid recipient: Test Notification
2019-08-22 17:54:12.367 [WARN ] [t.internal.handler.PushbulletHandler] - Message will be broadcast to all user's devices.
2019-08-22 17:54:12.368 [DEBUG] [t.internal.handler.PushbulletHandler] - Push: Push {title='', body='Test 2.x', type='note', email='null', channelTag='null'}
2019-08-22 17:54:12.368 [DEBUG] [t.internal.handler.PushbulletHandler] - Packed Request: {"title":"","body":"Test 2.x","type":"note"}
@hmerk
Copy link
Contributor

hmerk commented Jul 25, 2021

closed due to inactivity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants