New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Smoke tests for openHAB-cloud #113
Comments
openHAB has both a TravisCI and cloudbees account for builds and testing, if someone wants to tackle this I would be happy to get them access to one or both. |
@digitaldan & FlorianSW, I was thinking about this also since long, but had a lot to do. I would tackle it after I finished the Google Home openHAB action (thats why I am a little quite :-) ). Br Mehmet |
From my point of view, the tests should be runnable on every system, so everyone would be able to setup the repo to allow running each kind of test (e.g. as an npm task or bundled with npm test). Afterwards we can take a look how and what tests we will run using Travis or Jenkins :) @marziman I think there's no open PR that explicitly needs a review from you, except probably #98, however, @digitaldan is already quite active there :) |
Closing this with #122 |
In PR #97 and in some others I don't remember anymore, I made some changes and updated the PR with a merge of master and made a simple small mistake during the conflict resolution. While I would agree, that I would need to be more careful about these little kind of things (:P), I would love some smoke tests more :D
In my vision the tests would try to run app.js and look at any error message during startup and fail, if there're any and stop the instance and proceed with unit tests after it. We could probably extend the tests with requesting some endpoints later, however, just starting app.js sounds like a good idea for now.
The text was updated successfully, but these errors were encountered: