Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apple Notifications issues #151

Closed
digitaldan opened this issue Jan 20, 2018 · 2 comments
Closed

Apple Notifications issues #151

digitaldan opened this issue Jan 20, 2018 · 2 comments

Comments

@digitaldan
Copy link
Contributor

@FlorianSW we just deployed the latest code that includes the new routes (from Aug), I know that was a while ago :-) There seems to be a few issues at least with the Apple Notification class, I have it crudely patched in production, but I was hoping for a more elegant fix.

on https://github.com/openhab/openhab-cloud/blob/master/mobileregistrationservice/AppleRegistrationService.js#L28 this probably needs to be self.getDeviceId as it was throwing an error that deviceId was not defined

also the same here https://github.com/openhab/openhab-cloud/blob/master/mobileregistrationservice/AppleRegistrationService.js#L52

Finally https://github.com/openhab/openhab-cloud/blob/master/mobileregistrationservice/AppleRegistrationService.js#L48 throws an error that it can't instantiate info on an undefined object, so getLogger is returning undefined.

can you take a look?

@FlorianSW
Copy link
Member

I'll take a look into this! Sorry for the problems that this made :/

@EjvindHald
Copy link

EjvindHald commented Jan 30, 2018

The IOS app has recently not been updating icons using myopenHAB when the state changes, and it used to work perfectly. Now the icons in the IOS app only change state correct, if it is a local connection.

See examples here and here

Could it be related to what @digitaldan mentioned in this thread?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants