LightwaveRf Binding #2289

foxy82 · 2015-03-13T16:36:17Z

No description provided.

recommened on the mailing list.

Changing Mood switches to work as Numbers rather than strings as

Adding first commit of empty Lightwaverf module

Conflicts: bundles/binding/pom.xml

Merge from Master

Conflicts: bundles/binding/pom.xml

…lightwaverf Conflicts: bundles/binding/pom.xml

first implementations of sender and receiver

…lightwaverf

…er that isn't needed

teichsta · 2015-05-20T14:24:15Z

...g.lightwaverf/src/main/java/org/openhab/binding/lightwaverf/internal/LightwaveRfBinding.java

+	}
+
+	private void publishUpdate(List<String> itemNames, LightwaveRFCommand message, LightwaveRfBindingProvider provider) {
+		logger.info("Publishing Update {} to {}",message, itemNames);


decrease to DEBUG level

teichsta · 2015-05-20T14:38:46Z

Hi @foxy82,

please find my review comments inline and some general comments below.

update @SInCE to 1.7.0
add javadoc for ALL class on class level and (at least) for all public methods
use the Eclipse Code Formatter for all classes
move the UnitTests into their own bundle ".test” (see other test bundles as sample)
add binding to distribution/pom.xml

And finally squash your commits into one once you've incorporated my feedback.

Thanks, Thomas E.-E.

buildhive · 2015-05-20T17:29:34Z

openhab » openhab #3020 FAILURE
Looks like there's a problem with this pull request
(what's this?)

teichsta · 2015-05-21T20:06:09Z

if you could finally squash your commits into one i am ready to merge … Thanks, Thomas E.-E.

teichsta · 2015-05-23T06:33:41Z

any chance to get this squashed today?

foxy82 · 2015-05-23T07:21:54Z

Hey,

I'll try to do it later today.

Neil
On 23 May 2015 07:33, "Thomas Eichstädt-Engelen" notifications@github.com
wrote:

any chance to get this squashed today?

—
Reply to this email directly or view it on GitHub
#2289 (comment).

teichsta · 2015-05-24T06:47:47Z

@foxy82 ?

foxy82 · 2015-05-24T08:24:32Z

Hi,

I've incorporated the following: fixed javadoc, fixed headers, removed tests from the binding directory, formatting.

I haven't done the comments for public methods yet or squashed it into one commit.

I need to go out now I'll try to do the squash in about 3 hours. If you need this today I'm not likely to be able to add the comments that will need to be a later update.

buildhive · 2015-05-24T08:49:23Z

openhab » openhab #3060 FAILURE
Looks like there's a problem with this pull request
(what's this?)

teichsta · 2015-05-24T10:02:16Z

ok, thanks! The most important thing would be to squash your commits into one and to create the according wiki page. Best, Thomas E.-E.

foxy82 · 2015-05-24T10:45:38Z

I'm trying to squash now but I don't know Git very well. I'm following this: http://blog.steveklabnik.com/posts/2012-11-08-how-to-squash-commits-in-a-github-pull-request

but something must be going wrong as loads of commits are conflicting I've only managed to get to 10 of 121 if it persists at this pace I'm not going to have time to do it.

If there is anything wrong with those instructions let me know.

teichsta · 2015-05-24T10:52:26Z

we generally recommend this howto: https://github.com/ginatrapani/todo.txt-android/wiki/Squash-All-Commits-Related-to-a-Single-Issue-into-a-Single-Commit

teichsta · 2015-05-24T10:55:32Z

i can squash for you but then i will be author here on github. If you are fine with that we can go that way, too …

foxy82 · 2015-05-24T11:01:48Z

Following that - I don't know how to find how many commits I need for the HEAD~4 bit just done 20 commits successfully but now it is asking about merge conflicts in db4o modules. I wonder if I've mucked up my fork when trying to pull in upstream changes.

@SInCE

Update openhab_default.cfg Updated with lightwaverf settings Updated with correct case Log when we don't use a message. Updated Updated Updated to publish message when no config Update AbstractLightwaveRfCommand.java Add License header and @author and @SInCE tags Update LightwaveRFActivator.java Fix since tag Update LightwaveRFReceiver.java Add License header and @authoer and @SInCE tags Update LightwaveRFSender.java Add License header and @author and @SInCE tags Update LightwaveRfHeatPoller.java Add License header and @author and @SInCE tags Update LightwaveRfType.java Add License header and @author and @SInCE tags Update LightwaverfConvertor.java Add License header and @author and @SInCE tags Update LightwaveRfMessageException.java Add License header and @author and @SInCE tags Update LightwaveRFMessageListener.java Add License header and @author and @SInCE tags Update LightwaveRfDeviceId.java Add License header and @author and @SInCE tags Update LightwaveRfGeneralMessageId.java Add License header and @author and @SInCE tags Update LightwaveRfHeatingMessageId.java Add License header and @author and @SInCE tags Update LightwaveRfMessageId.java Add License header and @author and @SInCE tags Update LightwaveRfRoomDeviceIdentifier.java Add License header and @author and @SInCE tags Update LightwaveRFCommand.java Add License header and @author and @SInCE tags Update LightwaveRFStopPublisherCommand.java Add License header and @author and @SInCE tags Update LightwaveRfCommandOk.java Add License header and @author and @SInCE tags Update LightwaveRfDeviceRegistrationCommand.java Add License header and @author and @SInCE tags Update LightwaveRfDimCommand.java Add License header and @author and @SInCE tags Update LightwaveRfHeatInfoRequest.java Add License header and @author and @SInCE tags Update LightwaveRfHeatingInfoResponse.java Add License header and @author and @SInCE tags Update LightwaveRfMessageType.java Add License header and @author and @SInCE tags Update LightwaveRfOnOffCommand.java Add License header and @author and @SInCE tags Update LightwaveRfRoomDeviceMessage.java Add License header and @author and @SInCE tags Update LightwaveRfRoomMessage.java Add License header and @author and @SInCE tags Update LightwaveRfSerialMessage.java Add License header and @author and @SInCE tags Update LightwaveRfSetHeatingTemperatureCommand.java Add License header and @author and @SInCE tags Update LightwaveRfVersionMessage.java Add License header and @author and @SInCE tags Update MANIFEST.MF Remove export line Update AbstractLightwaveRfCommand.java Adding documentation of class use Update LightwaveRFReceiver.java Update documentation Update LightwaveRFSender.java Update comments Update LightwaverfConvertor.java Update comments Update LightwaveRfType.java Update comments Update LightwaveRfHeatPoller.java Update comments Update LightwaveRfBinding.java Downgraded log level. Removed generic comments. Update LightwaveRfHeatingInfoResponse.java Move comment to class level Update LightwaveRfOnOffCommand.java Move comment. Update LightwaveRfSetHeatingTemperatureCommand.java Update comments and remove commented code. Update LightwaveRFSenderTest.java Remove comments. Update LightwaveRFSender.java Fix comments Move tests to a seperate directory and format code. Fix header date to 2015 Added lightwaverf to distributionn/pom.xml

foxy82 · 2015-05-24T11:46:09Z

I've managed to squash some but the next one is just conflicting really badly - I don't know why - all I want is all files in the status they are in the very last commit as a single commit for the whole binding. I don't have time to do any more I'll have to look again if I get some time next week. I don't mind if you are able to squash them and it sets you as the author - or if you know a simple command I can run to just flatten it taking the HEAD as the final copy and not worrying about the merge conflicts in the middle.

buildhive · 2015-05-24T11:52:04Z

openhab » openhab #3063 FAILURE
Looks like there's a problem with this pull request
(what's this?)

buildhive · 2015-05-24T11:52:16Z

openhab » openhab #3064 FAILURE
Looks like there's a problem with this pull request
(what's this?)

buildhive · 2015-05-24T11:52:28Z

openhab » openhab #3065 FAILURE
Looks like there's a problem with this pull request
(what's this?)

teichsta · 2015-05-25T05:33:21Z

i've merged this PR manually. Please keep in mind to create the according Wiki page and link to it here and on the Release-Notes page (see https://github.com/openhab/openhab/wiki/Release-Notes-1.7). Thanks, Thomas E.-E.

foxy82 added 30 commits July 19, 2014 16:58

First addition of empty LightwaveRF binding.

30f09bd

Merge branch 'master' of https://github.com/foxy82/openhab

6e85bfd

Also commit new Binding pom.

06c92ed

Fix incorrect version in files

2151a97

Changing Mood switches to work as Numbers rather than strings as

f99f459

recommened on the mailing list.

Merge pull request #2 from foxy82/rfxcom

02dd014

Changing Mood switches to work as Numbers rather than strings as

Merge pull request #3 from foxy82/lightwaverf

6a250d3

Adding first commit of empty Lightwaverf module

Merge remote-tracking branch 'upstream/master'

998cc90

Conflicts: bundles/binding/pom.xml

Merge pull request #4 from foxy82/master

099676a

Merge from Master

Merge remote-tracking branch 'upstream/master'

f2a574f

Merge remote-tracking branch 'upstream/master' into lightwaverf

a2788e3

Conflicts: bundles/binding/pom.xml

Merge branch 'lightwaverf' of https://github.com/foxy82/openhab into …

6f69a42

…lightwaverf Conflicts: bundles/binding/pom.xml

Starting to implement the LightwaveRF binding. Added Config parser and

0af5c7e

first implementations of sender and receiver

Merge branch 'master' of https://github.com/foxy82/openhab

5659e72

Updating files

1106271

Updated

bc714a8

Interim commit of files:q

6310610

Adding new connector to do all the socket code

ee1f481

Changing to polling binding

ee5a1eb

Merge branch 'lightwaverf' of https://github.com/foxy82/openhab into …

92e06ab

…lightwaverf

Addational changes to the Connector

71740ae

Updated the Sender and receiver to work correctly and deleted connect…

e76b07b

…er that isn't needed

not sure

bdbcd22

Adding extra binding files - still a work in progress

68fd25a

Update LightwaveRfDimUpDownCommand.java

0959d53

Update LightwaveRfOnOffCommand.java

dbbc055

Update LightwaveRfDimUpDownCommand.java

beb525f

Update LightwaveRfOnOffCommand.java

5cb6745

Update LightwaveRfDimCommand.java

38d616a

Update LightwaverfConvertor.java

786bf7a

teichsta reviewed May 20, 2015
View reviewed changes

teichsta added the awaiting-feedback label May 20, 2015

teichsta closed this in 02944b1 May 25, 2015

teichsta removed the awaiting-feedback label May 25, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LightwaveRf Binding #2289

LightwaveRf Binding #2289

foxy82 commented Mar 13, 2015

teichsta May 20, 2015

teichsta commented May 20, 2015

buildhive commented May 20, 2015

teichsta commented May 21, 2015

teichsta commented May 23, 2015

foxy82 commented May 23, 2015

teichsta commented May 24, 2015

foxy82 commented May 24, 2015

buildhive commented May 24, 2015

teichsta commented May 24, 2015

foxy82 commented May 24, 2015

teichsta commented May 24, 2015

teichsta commented May 24, 2015

foxy82 commented May 24, 2015

foxy82 commented May 24, 2015

buildhive commented May 24, 2015

buildhive commented May 24, 2015

buildhive commented May 24, 2015

teichsta commented May 25, 2015

LightwaveRf Binding #2289

LightwaveRf Binding #2289

Conversation

foxy82 commented Mar 13, 2015

teichsta May 20, 2015

Choose a reason for hiding this comment

teichsta commented May 20, 2015

buildhive commented May 20, 2015

teichsta commented May 21, 2015

teichsta commented May 23, 2015

foxy82 commented May 23, 2015

teichsta commented May 24, 2015

foxy82 commented May 24, 2015

buildhive commented May 24, 2015

teichsta commented May 24, 2015

foxy82 commented May 24, 2015

teichsta commented May 24, 2015

teichsta commented May 24, 2015

foxy82 commented May 24, 2015

foxy82 commented May 24, 2015

buildhive commented May 24, 2015

buildhive commented May 24, 2015

buildhive commented May 24, 2015

teichsta commented May 25, 2015