This repository has been archived by the owner on May 17, 2021. It is now read-only.
Small fix to avoid NullPointerException #2482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
openhab » openhab #2811 SUCCESS |
| @@ -334,7 +334,7 @@ public void internalReceiveCommand(String itemName, Command command) { | |||
| for (MaxCubeBindingProvider provider : providers) { | |||
| serialNumber = provider.getSerialNumber(itemName); | |||
|
|
|||
| if (serialNumber.equals(null)) { | |||
| if (serialNumber==null || serialNumber.isEmpty()) { | |||
There was a problem hiding this comment.
please use StringUtils.isBlank() instead
|
Hi @marcelrv thanks for this Fix. Please find my comment and finally please squash your commits into one. Thanks, Thomas E.-E. |
|
Hi @teichsta , |
|
openhab » openhab #2814 SUCCESS |
not quite :-) isBlank() already contains the "null check" … |
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
|
ah.. did not know that :-( |
teichsta
added a commit
that referenced
this pull request
Apr 20, 2015
Small fix to avoid NullPointerException
|
yep, thanks! |
|
openhab » openhab #2816 SUCCESS |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as .equals(null) is not a correct check
Signed-off-by: Marcel Verpaalen marcel@verpaalen.com