This repository has been archived by the owner on May 17, 2021. It is now read-only.
Added telnet SerialPort implementation #2832
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SerialPort can be accessed remotely via telnet. Changing serial port parameters is allowed via RFC2217. Tested with ser2net on the server side. Compatible with nrjavaserial (few methods are not supported as they mainly makes no sense on a tcp session).
|
Thanks @msteigenberger will have a look soon. Best, Thomas E.-E. |
|
Can one of the admins verify this PR? |
|
Not clear to me whether OH can use this code, as it's copied from copyrighted code. Any @openhab/maintainers able to comment? |
|
In the meantime this code was included into nrjavaserial itself. We can close this PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SerialPort can be accessed remotely via telnet. Changing serial port
parameters is allowed via RFC2217. Tested with ser2net on the server
side. Compatible with nrjavaserial (few methods are not supported as
they mainly makes no sense on a tcp session).
The work is based on (or more or less a copy with some changes) of https://github.com/archiecobbs/jvser/.