This repository has been archived by the owner on May 17, 2021. It is now read-only.
MiOS Binding: Issue #3317 Tracking last used pin on locks. #3377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiOS Item Generator (XSLT) incorrectly generated the `sl_UserCode`
UPnP attribute as `Number` type instead of String type.
Fix involves:
a) Emitting original value as String type, which is of the form:
"UserID=".+" UserName=".*"
b) Emitting new Item declaration `*UserCode_userid` representing the
_UserID_ value encoded in the original value (`Number`).
c) Emitting new Item declaration `*UserCode_username` representing
the _UserName_ value encoded in the original value (`String`).
d) When transforming multiply-bound source values, avoid destroying
the original/untransformed value.
Signed-off-by: Mark Clark <mr.guessed@gmail.com>
teichsta
added a commit
that referenced
this pull request
Nov 6, 2015
MiOS Binding: Issue #3317 Tracking last used pin on locks.
|
Thanks @mrguessed! |
|
Thanks @teichsta, appreciate the merge! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix for Issue #3317 Tracking last used pin on locks.
MiOS Item Generator (XSLT) incorrectly generated the
sl_UserCodeUPnP attribute asNumbertype instead ofStringtype.Fix involves:
a) Emitting original value as
Stringtype, which is of the form:b) Emitting new Item declaration
*UserCode_useridrepresenting the UserID value encoded in the original value (Number).c) Emitting new Item declaration
*UserCode_usernamerepresenting the UserName value encoded in the original value (String).d) When transforming multiply-bound source values, avoid destroying the original/untransformed value.
e) Tighten the parse logic to work better with Transformations (like
REGEX) that have complex parameters.Note: Online docs will be updated once the PR is in the codebase. The fix isn't isolated to the MiOS Item Generator code, but it helped me find an issue found in the MiOS Binding, which needed to be fixed for it all to work together cleanly
Signed-off-by: Mark Clark mr.guessed@gmail.com