This repository has been archived by the owner on May 17, 2021. It is now read-only.
[novelanheatpump] Add port config parameter (for #3607) #3615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hakan42, would you mind giving this PR a read through before it's merged? OK to merge if you think it's ready. Thank you. |
| String ip = null; | ||
| try { | ||
| String refreshIntervalString = (String) config.get("refresh"); //$NON-NLS-1$ | ||
| refreshInterval = StringUtils.isNotBlank(refreshIntervalString) ? |
There was a problem hiding this comment.
for the sake of readability you could statically import isNotBlank()
|
Thanks for this contribution @watou. See some minor comments inline … |
watou
force-pushed
the
novelanheatpump-port-config
branch
from
7013fc6
to
8a680d0
Compare
|
Thank you, @teichsta. Updated and squashed. |
teichsta
added a commit
that referenced
this pull request
Dec 29, 2015
[novelanheatpump] Add port config parameter (for #3607)
|
great thanks @watou! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added port config parameter for #3607.