This repository has been archived by the owner on May 17, 2021. It is now read-only.
[sallegra] Added Sallegra binding (replaces #3520) #3680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@hakan42 could you read through this PR quickly and merge if you think it looks good? |
|
Will do but it might take me another hour or so. |
|
What immediately comes to attention :
|
|
@teichsta correct -- just another set of eyes quickly before merge. I will rebase and squash, and then please quickly review and merge. Thank you! |
watou
force-pushed
the
sallegra_binding
branch
from
54eb61c
to
5497a31
Compare
|
Let me add the openhab_default.cfg section and squash. |
watou
force-pushed
the
sallegra_binding
branch
from
5497a31
to
859d5ba
Compare
|
ok, i've recently (a second ago) merged another PR which will break the openhab_default.cfg compatibility again … |
|
fixing that now! |
|
ah, sorry my fault i didn't see squashed already, sorry, sorry! |
watou
force-pushed
the
sallegra_binding
branch
from
859d5ba
to
e8a01de
Compare
|
OK someone please check through and merge this before I go mad! 😄 |
teichsta
added a commit
that referenced
this pull request
Jan 2, 2016
[sallegra] Added Sallegra binding (replaces #3520)
|
done, thanks @watou! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See wiki here.
Changed from copy of #3520 by formatting changes, resolve merge conflicts, etc.