This repository has been archived by the owner on May 17, 2021. It is now read-only.
MiOS Binding - Dimming controls not working in openHAB2 #3926 #3932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Under openHAB 1.x, the MAP Transform returns "" or null, when no transformation is performied. Under the compat1x layer, the MAP Transform returns the input/source value. Signed-off-by: Mark Clark <mr.guessed@gmail.com>
|
lgtm. Is there an issue open against the inconsistent behaviour of transforms from OH1 to ESH, and even among transforms on the same platform? IOW, make it consistent, but don't break anything? 😃 |
|
I initiated the discussion in the community forum first. Once I get confirmation I'll create an issue for it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under openHAB 1.x, the
MAPTransform returns""ornull, when no transformation is performed.Under the compat1x layer, the
MAPTransform returns the input/source value.This change addresses issue #3926, and ensures the MiOS Binding handles either type of result.
Signed-off-by: Mark Clark mr.guessed@gmail.com