This repository has been archived by the owner on May 17, 2021. It is now read-only.
DSC Alarm: Fix Premature Setting of Partition Arm Mode Item #4416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The binding would prematurely set the item PARTITION_ARM_MODE when issuing a partition arm command. This would sometimes show that the partition was armed when it actually wasn't. This fixes that situation by only setting the item when a verification message is received from the alarm system.
|
Thanks @RSStephens! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The binding would prematurely set the item
PARTITION_ARM_MODEwhen issuing a partition arm command. This would sometimes show the partition as being armed when it actually wasn't. This fixes that situation by only setting the item when a verification message is received from the alarm system. This issue was brought to light on the openHAB community website here.