Initial commit for wago binding [new attempt]

[BinaryCraX]

No description provided.

[buildhive]

openhab » openhab #508 FAILURE
Looks like there's a problem with this pull request
(what's this?)

[BinaryCraX]

What gone wrong? The stack trace conveys nothing to me.

[teichsta]

Hi, thanks for this update! While browsing through your code i've found some general issues:

• please change license to EPL (please use maven-license-plugin to bulk change your files)
• there a still some files which needs a newline at their end
• please do not checkin in html files

I am still not sure if adding the wimpi-modbus lib as source files is the best solution. Isn't there a binary distribution that could be used in your binding?

Best, Thomas E.-E.

[BinaryCraX]

Hi,
There is a binary distribution of the wimpi modbus lib, but the lib is licensed under the Apache License 2. How do I correctly integrate the lib into OpenHAB and where should I put the licensefile?
(Notice: The lib can be found on maven central http://search.maven.org/#artifactdetails%7Cnet.wimpi%7Cjamod%7C1.2%7Cjar )

[teichsta]

How do I correctly integrate the lib into OpenHAB and where should I put the license file? (Notice: The lib can be found on maven central

please add a new lib folder an add the lib into this folder. Also it to the bundles class path, MANIFEST.MF and build.properties (see e.g. org.openhab.binding.exec).

Best, Thomas E.-E.

[buildhive]

openhab » openhab #615 FAILURE
Looks like there's a problem with this pull request
(what's this?)

[buildhive]

openhab » openhab #617 FAILURE
Looks like there's a problem with this pull request
(what's this?)

[BinaryCraX]

I've replaced the tabs in the pom.xml of the bindings-directory with spaces. Because of this the merging fails, should I undo these changes?

[teichsta]

the comment seem to be cut off

[teichsta]

Hi, thanks for adding the 3rd party classes as lib. The binding looks quite good now. While grabbing through the code I've added some more issues (see inline comments). Thanks, Thomas E.-E.

[teichsta]

Any chance to get this done until Friday? Best, Thomas E.-E.

[BinaryCraX]

No, sorry. At the earliest it’s done on Sunday.

[teichsta]

which Sunday ;-)

[BinaryCraX]

eclipse always crashes because it relays on an old version of libxul. So I can't do anything until eclipse was fixed…

[moonnejs]

印象笔记无法提交笔记，原因如下：

本月帐户上传流量已经达到上限。

原消息详情：
来自：BinaryCraX <notifications@github.com>
发送到：mnejs.b4a0ee0@m.yinxiang.com
全部收件人：openhab/openhab <openhab@noreply.github.com>; moonnejs <mnejs.b4a0ee0@m.yinxiang.com>
主题：Re: [openhab] Initial commit for wago binding new attempt

为了防止邮件过多，接下来的360分钟内，你将不会收到报错回复。

升级到印象笔记高级帐户，可以发送的邮件数量将从50封提升到200封。
https://app.yinxiang.com/Checkout.action?origin=email%2Dcommerce

• 印象笔记团队

[teichsta]

any success meanwhile? How are we going to proceed with your contribution? Best, Thomas E.-E.

[buildhive]

openhab » openhab #1452 FAILURE
Looks like there's a problem with this pull request
(what's this?)

[teichsta]

any suggestion how to proceed with this PR?

[BinaryCraX]

The above mentioned bugs were fixed.
I have no clue why the build is still failing.
@teichsta: So, please can you help me, to get the things right?

[teichsta]

merged manually into master. Thanks @BinaryCraX, Best, Thomas E.-E.

[nickma82]

@BinaryCraX "eclipse always crashes"
I had a simmilar issue and downloaded the plugin developer version of eclipse lunar directly from the eclipse site. After choosing the same working-directory as with the old-crashing eclipse it worked perfeclty!

[BinaryCraX]

@nickma82 "eclipse always crashes"
Thank you very much for this tip :)

[teichsta]

the corresponding Wiki page for the Wago is still missing @BinaryCraX. Could you please add it?

[BinaryCraX]

@teichsta i've just added a basic documentation of the wago-binding to the Wiki. I'll complete it as soon as possible.