8812AU 8814AU support MCS 9-10-11-12-13-14-15 and up #22

roque-canales · 2019-02-05T09:10:12Z

Hello,

88XXAU chips can be used in MIMO mode for long range (MCS 9-10-11-12) or (VHT 2 Streams)

these board ar 2T2R.

For the moment, when using these boards only one antenna transmit. This is because we are using only one Stream mode (datarate MCS below 9)

I see that aircrack dkms 88xxAU driver is compatible with these multistreams mode (MIMO)

So it's open-hd that dont use these driver capability.

Does anybody could check this? maybe rodizio?

pilotnbr1 · 2019-02-05T23:53:33Z

It’s been discussed. Sounds like we have a guy that will play with it. Have you tried that feature?

Hoping someone more knowledgeable on the specifics will comment.

zipray · 2019-02-06T14:59:05Z

svpcom/wfb-ng@706af67

Yes21 · 2019-02-19T16:35:08Z

svpcom/wifibroadcast@706af67

What do you mean ?

Yes21 · 2019-02-19T16:37:01Z

Following the advice of @svpcom, we modified the core/rtw_xmit.c file from the driver :
replacing
u8 fixed_rate = MGN_1M, sgi = 0, bwidth = 0, ldpc = 0, stbc = 0;
by
u8 fixed_rate = MGN_1M, sgi = 0, bwidth = 0, ldpc = 0, stbc = 1;

But it didn't resolve the problem.

Do you think we could change this parameter with the .conf files ?

svpcom · 2019-02-19T16:47:58Z

I've made an experiment: replace second antenna with terminator (50 ohm load) and run tx on MCS8 rate. No any packets was received! So in case of MIMO (MCS8+) you must receive signal from all TX antennas (which is false in case of WFB where multiple antennas using for diversity). So you can use only STBC and not MIMO modes.

zipray · 2019-02-19T18:36:55Z

svpcom/wfb-ng@706af67

What do you mean ?
@Yes21 @svpcom
The expert's explanation is what I mean

svpcom · 2019-02-19T19:39:57Z

@Yes21 What problem do you want to solve? Enable STBC by default (it works by patching stbc = 1 in driver) or do this in runtume (need to rewrite code with hardcoded packet headers in https://github.com/HD-Fpv/Open.HD/blob/7c4519174f63b6de4defa6d08926c18717ec7fe9/wifibroadcast-base/tx_rawsock.c#L115 and add dynamic flags evaluation like is done in my code above)

zipray · 2019-02-19T19:59:27Z

@Yes21 What problem do you want to solve? Enable STBC by default (it works by patching stbc = 1 in driver) or do this in runtume (need to rewrite code with hardcoded packet headers in
and add dynamic flags evaluation like is done in my code above)
https://github.com/svpcom/wifibroadcast/blob/212f5c1d0151ddeba21ae19596e95bee80725887/src/wifibroadcast.hpp#L77

Yes21 · 2019-02-20T15:38:40Z

@Yes21 What problem do you want to solve?

The problem is to make the 2 antennas of AWUS036ACH (4 for AWUS1900) sending data in monitor mode.

Enable STBC by default (it works by patching stbc = 1 in driver) or do this in runtume (need to rewrite code with hardcoded packet headers in

Open.HD/wifibroadcast-base/tx_rawsock.c

Line 115 in 7c45191
0x04, 0x80, 0x00, 0x00, // <-- radiotap present flags (rate + tx flags)
and add dynamic flags evaluation like is done in my code above)

Do we just need to replace :
0x04, 0x80, 0x00, 0x00, // <-- radiotap present flags (rate + tx flags)
by :
0x00, 0x80, 0x08, 0x00, // <-- radiotap present flags: RADIOTAP_TX_FLAGS + RADIOTAP_MCS
??

svpcom · 2019-02-20T17:58:47Z

#define IEEE80211_RADIOTAP_MCS_HAVE_BW    0x01
#define IEEE80211_RADIOTAP_MCS_HAVE_MCS   0x02
#define IEEE80211_RADIOTAP_MCS_HAVE_GI    0x04
#define IEEE80211_RADIOTAP_MCS_HAVE_FMT   0x08

#define IEEE80211_RADIOTAP_MCS_BW_20    0
#define IEEE80211_RADIOTAP_MCS_BW_40    1
#define IEEE80211_RADIOTAP_MCS_BW_20L   2
#define IEEE80211_RADIOTAP_MCS_BW_20U   3
#define IEEE80211_RADIOTAP_MCS_SGI      0x04
#define IEEE80211_RADIOTAP_MCS_FMT_GF   0x08
#define IEEE80211_RADIOTAP_MCS_HAVE_FEC   0x10
#define IEEE80211_RADIOTAP_MCS_HAVE_STBC  0x20

#define IEEE80211_RADIOTAP_MCS_FEC_LDPC   0x10
#define	IEEE80211_RADIOTAP_MCS_STBC_MASK  0x60
#define	IEEE80211_RADIOTAP_MCS_STBC_1  1
#define	IEEE80211_RADIOTAP_MCS_STBC_2  2
#define	IEEE80211_RADIOTAP_MCS_STBC_3  3
#define	IEEE80211_RADIOTAP_MCS_STBC_SHIFT 5

#define MCS_KNOWN (IEEE80211_RADIOTAP_MCS_HAVE_MCS | IEEE80211_RADIOTAP_MCS_HAVE_BW | IEEE80211_RADIOTAP_MCS_HAVE_GI | IEEE80211_RADIOTAP_MCS_HAVE_STBC | IEEE80211_RADIOTAP_MCS_HAVE_FEC)

// For MCS#1 -- QPSK 1/2 20MHz long GI + STBC
#define MCS_FLAGS  (IEEE80211_RADIOTAP_MCS_BW_20 | (IEEE80211_RADIOTAP_MCS_STBC_1 << IEEE80211_RADIOTAP_MCS_STBC_SHIFT))
#define MCS_INDEX  1

static uint8_t radiotap_header[]  __attribute__((unused)) = {
    0x00, 0x00, // <-- radiotap version
    0x0d, 0x00, // <- radiotap header length
    0x00, 0x80, 0x08, 0x00, // <-- radiotap present flags:  RADIOTAP_TX_FLAGS + RADIOTAP_MCS
    0x08, 0x00,  // RADIOTAP_F_TX_NOACK
    MCS_KNOWN , MCS_FLAGS, MCS_INDEX // bitmap, flags, mcs_index
};

svpcom · 2019-02-20T17:59:41Z

This code is for set MCS modes (802.11n), not for legacy modes (802.11a/b/g)

svpcom · 2019-02-20T18:02:04Z

for MCS#1 -- QPSK 1/2 20MHz long GI without STBC

#define MCS_FLAGS  (IEEE80211_RADIOTAP_MCS_BW_20)

for stbc + ldpc:

#define MCS_FLAGS  (IEEE80211_RADIOTAP_MCS_BW_20 | (IEEE80211_RADIOTAP_MCS_STBC_1 << IEEE80211_RADIOTAP_MCS_STBC_SHIFT) | IEEE80211_RADIOTAP_MCS_FEC_LDPC)

roque-canales · 2019-02-21T14:15:41Z

Hello SVP, so with this mod,, 88XXau board transmit same radio data through there 2 or 4 antennas ?

Idea is to have capability to receive data on the ground even if one antenna is NLOS.....

svpcom · 2019-02-21T15:58:22Z

@roque-canales Yes, see https://en.wikipedia.org/wiki/Space%E2%80%93time_block_code for reference.

roque-canales · 2019-02-21T17:39:13Z

Thank you,

Yes is exactly this feature that I wait to be released on image.

I'm not expert user for compile image with this feature.

Could you please release an image with this feature activated for 88xxAU users ?

Yes21 · 2019-02-21T19:59:07Z

I'm trying to implement this code in Open.HD.
Please wait. I will share an image if it works ...

Yes21 · 2019-02-22T18:31:18Z

@roque-canales, if you want to test it, no need to build an image.
Just replace the "/home/pi/wifibroadcast-base/tx_rawsock.c" file by the one attached here, and execute "sudo make" in the "wifibroadcast-base/" directory. This should be done from a running Pi.

tx_rawsock.c.txt

(delete the .txt extension)

svpcom · 2019-02-22T18:57:50Z

@Yes21
This fragment is invalid:

static u8 u8aRadiotapHeader[] = {
	 0x00, 0x00, // <-- radiotap version
    0x0d, 0x00, // <- radiotap header length
    0x00, 0x80, 0x08, 0x00, // <-- radiotap present flags:  RADIOTAP_TX_FLAGS + RADIOTAP_MCS
    0x08, 0x00,  // RADIOTAP_F_TX_NOACK
    MCS_KNOWN , 0x00, 0x00 // bitmap, flags, mcs_index
};

If you set MCS_KNOWN you must use MCS modes, but not legacy rates:

{
    0x00, 0x00, // <-- radiotap version
    0x0d, 0x00, // <- radiotap header length
    0x00, 0x80, 0x08, 0x00, // <-- radiotap present flags:  RADIOTAP_TX_FLAGS + RADIOTAP_MCS
    0x08, 0x00,  // RADIOTAP_F_TX_NOACK
    MCS_KNOWN , MCS_FLAGS, MCS_INDEX // bitmap, flags, mcs_index
};

Also you need to rewrite packet_header_init(uint8_t *packet_header, int type, int rate, int port) to set rate via MCS_FLAGS and MCS_INDEX fields but not with legacy rates.

Yes21 · 2019-02-22T20:08:02Z

If you set MCS_KNOWN you must use MCS modes, but not legacy rates:

{
    0x00, 0x00, // <-- radiotap version
    0x0d, 0x00, // <- radiotap header length
    0x00, 0x80, 0x08, 0x00, // <-- radiotap present flags:  RADIOTAP_TX_FLAGS + RADIOTAP_MCS
    0x08, 0x00,  // RADIOTAP_F_TX_NOACK
    MCS_KNOWN , MCS_FLAGS, MCS_INDEX // bitmap, flags, mcs_index
};

Ok, with this settings, it seems that the 2 antennas of 036ACH are sending !
A great step in the right direction ...

Also you need to rewrite packet_header_init(uint8_t *packet_header, int type, int rate, int port) to set rate via MCS_FLAGS and MCS_INDEX fields but not with legacy rates.

I will look for this later ...

And many thanks Vasily for your help and your patience !!

roque-canales · 2019-02-25T13:41:14Z

Hello,
@svpcom:
Also you need to rewrite packet_header_init(uint8_t *packet_header, int type, int rate, int port) to set rate via MCS_FLAGS and MCS_INDEX fields but not with legacy rates.

could you please tell me the values that need to be replaced ?

switch (rate) {
    case 1:
	u8aRadiotapHeader[8]=0x02;
	break;
    case 2:
	u8aRadiotapHeader[8]=0x04;
	break;
    case 5: // 5.5
	u8aRadiotapHeader[8]=0x0b;
	break;
    case 6:
	u8aRadiotapHeader[8]=0x0c;
	break;
    case 11:
	u8aRadiotapHeader[8]=0x16;
	break;
    case 12:
	u8aRadiotapHeader[8]=0x18;
	break;
    case 18:
	u8aRadiotapHeader[8]=0x24;
	break;
    case 24:
	u8aRadiotapHeader[8]=0x30;
	break;
    case 36:
	u8aRadiotapHeader[8]=0x48;
	break;
    case 48:
	u8aRadiotapHeader[8]=0x60;
	break;
    default:
	fprintf(stderr, "ERROR: Wrong or no data rate specified (see -d parameter)\n");
	exit(1);
	break;
}

memcpy(packet_header, u8aRadiotapHeader, sizeof(u8aRadiotapHeader));
pu8 += sizeof(u8aRadiotapHeader);

switch (type) {
    case 0: // short DATA frame
	fprintf(stderr, "using short DATA frames\n");
	port_encoded = (port * 2) + 1;
	u8aIeeeHeader_data_short[4] = port_encoded; // 1st byte of RA mac is the port
	memcpy(pu8, u8aIeeeHeader_data_short, sizeof (u8aIeeeHeader_data_short)); //copy data short header to pu8
	pu8 += sizeof (u8aIeeeHeader_data_short);
	break;
    case 1: // standard DATA frame
	fprintf(stderr, "using standard DATA frames\n");
	port_encoded = (port * 2) + 1;
	u8aIeeeHeader_data[4] = port_encoded; // 1st byte of RA mac is the port
	memcpy(pu8, u8aIeeeHeader_data, sizeof (u8aIeeeHeader_data)); //copy data header to pu8
	pu8 += sizeof (u8aIeeeHeader_data);
	break;
    case 2: // RTS frame
	fprintf(stderr, "using RTS frames\n");
	port_encoded = (port * 2) + 1;
	u8aIeeeHeader_rts[4] = port_encoded; // 1st byte of RA mac is the port
	memcpy(pu8, u8aIeeeHeader_rts, sizeof (u8aIeeeHeader_rts));
	pu8 += sizeof (u8aIeeeHeader_rts);
	break;
    default:
	fprintf(stderr, "ERROR: Wrong or no frame type specified (see -t parameter)\n");
	exit(1);
	break;
}

Kind regards

svpcom · 2019-02-25T13:49:58Z

replace first switch with

u8aRadiotapHeader[MCS_FLAGS_OFF] = mcs_flags;
u8aRadiotapHeader[MCS_IDX_OFF] = mcs_index;

roque-canales · 2019-02-25T14:04:10Z

Thank you :) ok and after?

svpcom · 2019-02-25T14:14:36Z

You need to replace

switch (rate) {
...
}

with this two lines.
mcs_flags is desired flags (depend what you want to enable: stbc, lpdc, 20 or 40 mhz channels)
mcs_index is number of mcs mode (from 0 to 7).

roque-canales · 2019-02-25T14:26:45Z

Ok so I supress the first switch with /* */, so the switch rate by the two lines you told upper.

/* switch (rate) {
case 1:
u8aRadiotapHeader[8]=0x02;
break;
case 2:
u8aRadiotapHeader[8]=0x04;
break;
case 5: // 5.5
u8aRadiotapHeader[8]=0x0b;
break;
case 6:
u8aRadiotapHeader[8]=0x0c;
break;
case 11:
u8aRadiotapHeader[8]=0x16;
break;
case 12:
u8aRadiotapHeader[8]=0x18;
break;
case 18:
u8aRadiotapHeader[8]=0x24;
break;
case 24:
u8aRadiotapHeader[8]=0x30;
break;
case 36:
u8aRadiotapHeader[8]=0x48;
break;
case 48:
u8aRadiotapHeader[8]=0x60;
break;
default:
fprintf(stderr, "ERROR: Wrong or no data rate specified (see -d parameter)\n");
exit(1);
break;
} */

u8aRadiotapHeader[MCS_FLAGS_OFF] = mcs_flags;
u8aRadiotapHeader[MCS_IDX_OFF] = mcs_index;

memcpy(packet_header, u8aRadiotapHeader, sizeof(u8aRadiotapHeader));
pu8 += sizeof(u8aRadiotapHeader);

switch (type) {
case 0: // short DATA frame
fprintf(stderr, "using short DATA frames\n");
port_encoded = (port * 2) + 1;
u8aIeeeHeader_data_short[4] = port_encoded; // 1st byte of RA mac is the port
memcpy(pu8, u8aIeeeHeader_data_short, sizeof (u8aIeeeHeader_data_short)); //copy data short header to pu8
pu8 += sizeof (u8aIeeeHeader_data_short);
break;
case 1: // standard DATA frame
fprintf(stderr, "using standard DATA frames\n");
port_encoded = (port * 2) + 1;
u8aIeeeHeader_data[4] = port_encoded; // 1st byte of RA mac is the port
memcpy(pu8, u8aIeeeHeader_data, sizeof (u8aIeeeHeader_data)); //copy data header to pu8
pu8 += sizeof (u8aIeeeHeader_data);
break;
case 2: // RTS frame
fprintf(stderr, "using RTS frames\n");
port_encoded = (port * 2) + 1;
u8aIeeeHeader_rts[4] = port_encoded; // 1st byte of RA mac is the port
memcpy(pu8, u8aIeeeHeader_rts, sizeof (u8aIeeeHeader_rts));
pu8 += sizeof (u8aIeeeHeader_rts);
break;
default:
fprintf(stderr, "ERROR: Wrong or no frame type specified (see -t parameter)\n");
exit(1);
break;
}

And after ? the code is ok or it need another upgrade?

I want to use stbc 20mhz.

roque-canales · 2019-02-25T15:37:04Z

@Yes21
It test your file but I Don't see any change on output.

Wich datarate you set? I test with 4 with no success.

zipray · 2019-02-25T15:42:19Z

@Yes21
It test your file but I Don't see any change on output.
Wich datarate you set? I test with 4 with no success.
Need delete tx rawsock.o and execute "sudo make tx_rawsock" in the "wifibroadcast-base/" directory.

Yes21 · 2019-02-25T18:36:03Z

@Yes21
It test your file but I Don't see any change on output.

Wich datarate you set? I test with 4 with no success.

There was an error in it.
Here is the later version :
tx_rawsock.c.txt

roque-canales · 2019-02-26T15:18:59Z

@svpcom

Hello Vasily, thank you so much for yesterday, now I'm trying to finish de rawsock file.

Could you please help me for activate STBC 20mhz.?

I bypass switch rate:
/* switch (rate) {……………….}*/

I write theses two lines below:

u8aRadiotapHeader[MCS_FLAGS_OFF] = mcs_flags;
u8aRadiotapHeader[MCS_IDX_OFF] = mcs_index;

and after what I must to do?

Thank you so much for help us.

svpcom · 2019-02-26T15:26:14Z

// offset of MCS_FLAGS and MCS index
#define MCS_FLAGS_OFF 11
#define MCS_IDX_OFF 12

// Settings for MCS#1 -- QPSK 1/2 20MHz long GI + STBC
#define MCS_FLAGS  (IEEE80211_RADIOTAP_MCS_BW_20 | (IEEE80211_RADIOTAP_MCS_STBC_1 << IEEE80211_RADIOTAP_MCS_STBC_SHIFT))
#define MCS_INDEX  1

If you want to select it statically - just remove switch (rate) {……………….} and add these defines before struct u8aRadiotapHeader definition. If you want to set radio modes based on command-line arguments - you need to write code (if or switch) which will parse them and set corresponding mcs_flags and mcs_index.

zipray · 2019-03-01T16:25:18Z

@Yes21
It test your file but I Don't see any change on output.
Wich datarate you set? I test with 4 with no success.

There was an error in it.
Here is the later version :
tx_rawsock.c.txt

https://github.com/Toradex-Apalis-TK1-AndroidTV/rtl8812_au_tx_power/blob/15e55fc8ab3940007c16b7cf391a129012582245/include/ieee80211.h

roque-canales · 2019-03-02T08:36:21Z

@svpcom

Hello Vasily could you please tell me the good values for activate stbc with 20mhz channel and datarate 4 equivalent rate?

Yes21 · 2019-03-02T17:58:39Z

https://github.com/Toradex-Apalis-TK1-AndroidTV/rtl8812_au_tx_power/blob/15e55fc8ab3940007c16b7cf391a129012582245/include/ieee80211.h

Hi @zipray, what do you want to show us with this link ?

svpcom · 2019-03-03T19:16:56Z

@roque-canales use

#define MCS_FLAGS  (IEEE80211_RADIOTAP_MCS_BW_20 | (IEEE80211_RADIOTAP_MCS_STBC_1 << IEEE80211_RADIOTAP_MCS_STBC_SHIFT))
#define MCS_INDEX  _mcs_index_from_table_

where _mcs_index_from_table_ is from http://mcsindex.com/
See orange column 20Mhz GI = 800ns for required bandwidth

roque-canales · 2019-03-04T21:31:16Z

Thank you Vasily

htcohio · 2019-07-12T19:30:45Z

Closing, refer to new combined rtl8812au issue
#115

pilotnbr1 added the enhancement New feature or request label Feb 21, 2019

pilotnbr1 added this to Candidates in Enhancements Feb 27, 2019

Yes21 mentioned this issue Apr 29, 2019

AWUS036ACH/AWUS1900 : only one antenna is sending data in monitor mode aircrack-ng/rtl8812au#280

Open

htcohio mentioned this issue Jul 12, 2019

8812AU Overall Optomizations (combined #115

Closed

htcohio closed this as completed Jul 12, 2019

Enhancements automation moved this from Candidates to Done Jul 12, 2019

8812AU 8814AU support MCS 9-10-11-12-13-14-15 and up #22

8812AU 8814AU support MCS 9-10-11-12-13-14-15 and up #22

Comments

roque-canales commented Feb 5, 2019

pilotnbr1 commented Feb 5, 2019 • edited

zipray commented Feb 6, 2019

Yes21 commented Feb 19, 2019

Yes21 commented Feb 19, 2019 • edited

svpcom commented Feb 19, 2019 • edited

zipray commented Feb 19, 2019

svpcom commented Feb 19, 2019

zipray commented Feb 19, 2019 • edited

Yes21 commented Feb 20, 2019

svpcom commented Feb 20, 2019

svpcom commented Feb 20, 2019

svpcom commented Feb 20, 2019

roque-canales commented Feb 21, 2019

svpcom commented Feb 21, 2019

roque-canales commented Feb 21, 2019

Yes21 commented Feb 21, 2019

Yes21 commented Feb 22, 2019

svpcom commented Feb 22, 2019 • edited

Yes21 commented Feb 22, 2019

roque-canales commented Feb 25, 2019 • edited

svpcom commented Feb 25, 2019 • edited

roque-canales commented Feb 25, 2019

svpcom commented Feb 25, 2019 • edited

roque-canales commented Feb 25, 2019 • edited

roque-canales commented Feb 25, 2019

zipray commented Feb 25, 2019

Yes21 commented Feb 25, 2019

roque-canales commented Feb 26, 2019

svpcom commented Feb 26, 2019 • edited

zipray commented Mar 1, 2019

roque-canales commented Mar 2, 2019

Yes21 commented Mar 2, 2019

svpcom commented Mar 3, 2019 • edited

roque-canales commented Mar 4, 2019

htcohio commented Jul 12, 2019

pilotnbr1 commented Feb 5, 2019 •

edited

Yes21 commented Feb 19, 2019 •

edited

svpcom commented Feb 19, 2019 •

edited

zipray commented Feb 19, 2019 •

edited

svpcom commented Feb 22, 2019 •

edited

roque-canales commented Feb 25, 2019 •

edited

svpcom commented Feb 25, 2019 •

edited

svpcom commented Feb 25, 2019 •

edited

roque-canales commented Feb 25, 2019 •

edited

svpcom commented Feb 26, 2019 •

edited

svpcom commented Mar 3, 2019 •

edited