Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OIDEndSessionRequest initializers lack correct nullability specifiers #565

Open
davedelong opened this issue Jul 25, 2020 · 0 comments · May be fixed by #702
Open

OIDEndSessionRequest initializers lack correct nullability specifiers #565

davedelong opened this issue Jul 25, 2020 · 0 comments · May be fixed by #702

Comments

@davedelong
Copy link

Are you filing an issue about iOS 12?
No

Describe the bug
OIDEndSessionRequest.h brackets its declarations with NS_ASSUME_NONNULL, which means that all object-typed parameters will be bridged into Swift as non-optional, unless otherwise specified.

The initializers to create an OIDEndSessionRequest allow you to pass in an idTokenHint:(NSString *)idTokenHint parameter, which lacks the nullable specifier. This means that in Swift, that parameter is bridged as String, and not String?.

The @property for this parameter correctly shows it as nullable, and the implementation allows for the underlying ivar to be nil, which means the initializer parameter should allow nil values as well.

The same applies to the postLogoutRedirectURL:(NSURL *)postLogoutRedirectURL and state:(NSString *)state parameters.

Expected behavior
These initializer parameters are declared as (nullable NS... *):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant