Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing port when constructing URL for token request #36

Closed
pntest opened this issue Mar 22, 2016 · 11 comments
Closed

Missing port when constructing URL for token request #36

pntest opened this issue Mar 22, 2016 · 11 comments
Assignees
Labels
Milestone

Comments

@pntest
Copy link

pntest commented Mar 22, 2016

In AuthorizationService::TokenRequestTask::doInBackground(), the URL that is constructed (local variable 'url' inside try block) is missing the port from the request URI. This omission seems to cause FileNotFoundException when connecting to the token endpoint.

@iainmcgin
Copy link
Member

Good find! Looks like we should be adding mRequestUri.getPort() if it is defined at library/java/net/openid/appauth/AuthorizationService.java#L234. I'll fix ASAP.

@iainmcgin iainmcgin added the bug label Mar 22, 2016
@iainmcgin iainmcgin added this to the 0.2.0 milestone Mar 22, 2016
@iainmcgin iainmcgin self-assigned this Mar 22, 2016
@pntest
Copy link
Author

pntest commented Mar 22, 2016

Thanks!
Is it possible to get a patch for 0.1.1 because I am using that version. Otherwise, when is 0.2.0 scheduled to become available?

@iainmcgin
Copy link
Member

Once I get this fixed, and the error handing in AuthState done (#26), I can cut a 0.2.0 release. I'll try and get that done for tomorrow to unblock you.

@pntest
Copy link
Author

pntest commented Mar 22, 2016

Thanks a lot!

@pntest
Copy link
Author

pntest commented Mar 22, 2016

Just one more request: if it could also be made available to satisfy a Gradle dependency, it would be very helpful.

@iainmcgin
Copy link
Member

Of course - when I cut a 0.2.0 build I'll update our bintray repo which should propagate to JCenter very quickly.

@iainmcgin
Copy link
Member

I'm just waiting for code reviews to get the necessary fixes for 0.2.0 in, hopefully we'll have this wrapped up by today.

@pntest
Copy link
Author

pntest commented Mar 24, 2016

No problem, thanks!

@iainmcgin
Copy link
Member

0.2.0 is now released; if it doesn't fix your issue, please re-open this bug.

@pntest
Copy link
Author

pntest commented Mar 28, 2016

Thanks.

@pntest
Copy link
Author

pntest commented Mar 29, 2016

The issue seems to be fixed in version 0.2.0. Thank you for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants