Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please move @types/jasmine to devDependencies #37

Closed
juriwiens opened this issue Nov 13, 2017 · 1 comment
Closed

Please move @types/jasmine to devDependencies #37

juriwiens opened this issue Nov 13, 2017 · 1 comment
Labels

Comments

@juriwiens
Copy link

Please move @types/jasmine to devDependencies, as it is needed for testing only.

It clashes with the @types/mocha in my project, as both of them use the same global identifier:

../../node_modules/@types/jasmine/index.d.ts(14,18): error TS2300: Duplicate identifier 'describe'.
../../node_modules/@types/jasmine/index.d.ts(16,18): error TS2300: Duplicate identifier 'xdescribe'.
../../node_modules/@types/jasmine/index.d.ts(25,18): error TS2300: Duplicate identifier 'it'.
../../node_modules/@types/jasmine/index.d.ts(35,18): error TS2300: Duplicate identifier 'xit'.
../../node_modules/@types/mocha/index.d.ts(36,13): error TS2300: Duplicate identifier 'describe'.
../../node_modules/@types/mocha/index.d.ts(37,13): error TS2300: Duplicate identifier 'xdescribe'.
../../node_modules/@types/mocha/index.d.ts(42,13): error TS2300: Duplicate identifier 'it'.
../../node_modules/@types/mocha/index.d.ts(43,13): error TS2300: Duplicate identifier 'xit'.
@tikurahul
Copy link
Collaborator

Acknowledged. Do you want to send me a PR for it ?

@tikurahul tikurahul added the bug label Nov 13, 2017
Meligy added a commit to Meligy/AppAuth-JS that referenced this issue Nov 13, 2017
Meligy added a commit to Meligy/AppAuth-JS that referenced this issue Nov 13, 2017
Meligy added a commit to Meligy/AppAuth-JS that referenced this issue Nov 13, 2017
Meligy added a commit to Meligy/AppAuth-JS that referenced this issue Nov 14, 2017
tikurahul pushed a commit that referenced this issue Nov 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants