incorporated subject identifiers from RFC9493 #57
Conversation
|
question to definition of
the examples only contain IPv4 adresses. But IPv4 is overaged and new systems must be IPv6 compatible. Question: should the ip address be typed in order to distinguish between multiple versions an formats? also, IPv6 address can be formatted ambiguously (see Issue #46 ) |
tulshi
requested review from
baboulebou,
davidjbrossard,
ggebel and
AllanFoster
|
I get the value of relying on another established spec for subject identification, but I think there are 2-3 important use-cases missing:
In addition, would it make sense to allow something like |
| @@ -46,6 +46,7 @@ normative: | |||
| RFC6750: #OAuth 2.0 Bearer Tokens | |||
| RFC8259: #JSON | |||
| RFC9110: # HTTP Semantics | |||
| RFC9493: # Subject Identifiers for SETs | |||
There was a problem hiding this comment.
| RFC9493: # Subject Identifiers for SETs | |
| RFC9493: # Subject Identifiers for Security Event Tokens |
|
|
||
| The following non-normative example describes a Subject: | ||
| The following is a non-normative example of a Subject Identifier Format of type Device Identifier: |
There was a problem hiding this comment.
| The following is a non-normative example of a Subject Identifier Format of type Device Identifier: | |
| The following is a non-normative example of a Subject Identifier Format of type Device Identifier: |
| @@ -383,7 +418,8 @@ X-Request-ID: bfe9eb29-ab87-4ca3-be83-a1d5d8305716 | |||
|
|
|||
| { | |||
| "subject": { | |||
| "id": "atul@sgnl.ai", | |||
| "format": "email", | |||
There was a problem hiding this comment.
I would suggest using account, iss_sub or opaque in examples rather than email.
email is a problematic subject identifier because canonicalization algorithms for email addressees aren't that well defined. In some edge cases, it's barely possible to canonicalize email addresses, as a bright example, both user@gmail.com and user+label1@gmail.com "represent" the same email address.
| ## IP Address {#ipaddress-registry-entry} | ||
|
|
||
| * Format Name: ip_address | ||
| * Format Description: A value that describes a subject through its IP Address |
There was a problem hiding this comment.
| * Format Description: A value that describes a subject through its IP Address | |
| * Format Description: A value that describes a subject through its IP address |
|
I am closing this PR as we've since done major rework to the API that voids the work done in this PR. |
No description provided.