Skip to content
This repository has been archived by the owner on Jul 24, 2023. It is now read-only.

Wishlist: Use PDO rather than Pear-DB, due to it's closer integration into the PHP core #63

Closed
JonTheNiceGuy opened this issue Oct 7, 2011 · 4 comments

Comments

@JonTheNiceGuy
Copy link
Contributor

This is something I plan to work on in the near future, however, it's more here in case anyone else wants to create the new SQL layer before I get around to it :)

@wrikken
Copy link

wrikken commented Jan 11, 2012

I'm definitely in favor of this.

@JonTheNiceGuy
Copy link
Contributor Author

I have created a patch for this, but it's breaking on the signature validation.

https://github.com/JonTheNiceGuy/php-openid/commit/583d894d82c0781996458afe5bd7c3255b58fa57

Could someone please review what (if anything) I'm doing wrong? Thanks!

@andig
Copy link

andig commented Nov 22, 2012

JonTheNiceGuy,

I don't think you need all that. I've done a

class Auth_OpenID_PDO_DatabaseConnection extends Auth_OpenID_DatabaseConnection 

and use that with an derived

Auth_OpenID_SQLiteStore

The only thing with the Auth_OpenID_SQLiteStore is that you have to overwrite the isError() as it depends on PEAR. Working sofar but not extensively tested.

@openid openid deleted a comment from linhdanhthue369 Jul 30, 2018
@timcappalli
Copy link
Member

This repo is being archived. Closing issue.

@timcappalli timcappalli closed this as not planned Won't fix, can't repro, duplicate, stale Jul 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants