Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Not very explicit" warning with rule containing <rule modifier> #276

Closed
don-vip opened this issue Dec 23, 2018 · 1 comment
Closed

"Not very explicit" warning with rule containing <rule modifier> #276

don-vip opened this issue Dec 23, 2018 · 1 comment
Assignees
@ypid
Labels
type: question Meta topic that is not about a bug or feature of the software.

Comments

@don-vip
Copy link

don-vip commented Dec 23, 2018 •
edited

Hello,
We added a new preset example in JOSM:
Mar-Jun closed; Jul-Feb open

We get the following warning:
opening_hours - Mar-Jun closed; Jul-Feb open <--- (This rule is not very explicit because there is no time selector being used. Please add a time selector to this rule or use a comment to make it more explicit.) => Mar-Jun closed; Jul-Feb open

From this comment it looks like a false positive?
@ypid ypid self-assigned this Jan 7, 2019
@ypid ypid added the type: question Meta topic that is not about a bug or feature of the software. label Jan 7, 2019
@ypid
Copy link
Member

ypid commented Jan 7, 2019

Sorry for the delay. I answered in the JSOM ticket directly. I am closing it here for now.

@ypid ypid closed this as completed Jan 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ypid ypid

Labels
type: question Meta topic that is not about a bug or feature of the software.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@don-vip @ypid