Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It is unclear what input fields are editable and what are not #347

Closed
Eiim opened this issue Oct 25, 2020 · 6 comments
Closed

It is unclear what input fields are editable and what are not #347

Eiim opened this issue Oct 25, 2020 · 6 comments
Labels
impact: browser type: feature Introduction of new functionality.

Comments

@Eiim
Copy link

Eiim commented Oct 25, 2020

The textboxes don't pull up the on-screen keyboard on my phone, making it impossible to type in them.

Chrome 86 on Android 10
@Eiim
Copy link
Author

Eiim commented Oct 25, 2020

Note: I came from https://openingh.openstreetmap.de/evaluation_tool/, which cites this repo for both the library and website, however, I'm not 100% certain if the website is actually included in this repo from a look at the readme. If it's not, sorry about that.

@ypid ypid added the type: question Meta topic that is not about a bug or feature of the software. label Oct 25, 2020
@ypid
Copy link
Member

ypid commented Oct 25, 2020

I cannot reproduce this. I also have a Android 10 with Bromite/Chromium 86 and the "value for "opening_hours"" and date fields bring up even the matching (#257) on-screen keyboard.

@Eiim
Copy link
Author

Eiim commented Oct 25, 2020

For some reason, I failed to notice that the only fields affected were state and country, which after playing with it on Desktop I now realize are driven by the lat/long fields. It might be nice to mark those boxes slightly differently, as I thought I could input them in lieu of coordinates (my phone currently has an issue preventing me from giving location access to websites), but regardless, this is definitely invalid.

@Eiim Eiim closed this as completed Oct 25, 2020
@ypid
Copy link
Member

ypid commented Oct 25, 2020

Right, the state and country fields are driven by the lat/long. I am currently not really the guy for UI/UX stuff. But I will keep this in the back of my mind as I agree with you.

@ypid ypid reopened this Oct 27, 2020
@ypid ypid added impact: browser type: feature Introduction of new functionality. and removed type: question Meta topic that is not about a bug or feature of the software. labels Oct 27, 2020
@ypid ypid changed the title On-screen keyboard doesn't trigger on mobile It is unclear what input fields are editable and what are not Oct 27, 2020
@KristjanESPERANTO KristjanESPERANTO mentioned this issue Nov 7, 2020
Merged
@KristjanESPERANTO
Copy link

I think a different look of the read-only fields would solve this. I created a PR. What do you think?

@ypid
Copy link
Member

ypid commented Nov 7, 2020

Thank you! This issue is closed by your PR that I just merged and deployed, #349.

@ypid ypid closed this as completed Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
impact: browser type: feature Introduction of new functionality.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ypid @Eiim @KristjanESPERANTO