Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Technically similar string but evaluated differently #400

Open
goodudetheboy opened this issue Jun 16, 2021 · 2 comments
Open

Technically similar string but evaluated differently #400

goodudetheboy opened this issue Jun 16, 2021 · 2 comments
Labels
type: bug A confirmed report of unexpected behavior.

Comments

@goodudetheboy
Copy link

I tried on these two (sort of) similar OH strings on the evaluator, but the result comes out differently:
Mo-Su 16:00-18:00, 19:00-21:00; Mo-Su 17:00-20:00 unknown
image
and
16:00-18:00, 19:00-21:00; 17:00-20:00 unknown
image

In the Features section, I read that If a rule's date condition overlap with previous rule, it overrides (as opposed to extends) the previous rule., but shouldn't the rules with unspecified dates also override?

@goodudetheboy goodudetheboy changed the title Technically similar string but evaluated differently? Technically similar string but evaluated differently Jun 16, 2021
@ypid ypid added the type: bug A confirmed report of unexpected behavior. label Jun 19, 2021
@ypid
Copy link
Member

ypid commented Jun 19, 2021

I think you are on to something. Looks like the library does not behave according to the specification.

@tim661811
Copy link

This is still an issue, using 08:00-18:00; We 08:00-12:00 gives completely other results as We 08:00-12:00; 08:00-18:00...
Using one schedule does state that at 13:00 state is open, using the other string the state is closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A confirmed report of unexpected behavior.
Projects
None yet
Development

No branches or pull requests

3 participants