Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle variable_dates for things from other calendars: Mid-Autumn Festival, Ramadan, ... #408

Open
3 tasks
Artoria2e5 opened this issue Aug 11, 2021 · 1 comment
Labels
status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation.

Comments

@Artoria2e5
Copy link

Artoria2e5 commented Aug 11, 2021

Since #406 brings up the issue of mid-autumn festival, I figured that I should open a tracking issue for handling non-trivial variable_dates generally stemming from other calendar systems. A list I can think of are:

  • Chinese and related lunisolar systems. Commonly tabulated due to pain of computation. But the CN/HK/TW tabulation will be off due to Viet Nam and Korea using their respective timezones.
  • Islamic and Hebrew lunar calendars. I thought these were tabulated by simple rules, but Added italian Public Holidays to opening_hours.js #74 (comment) mentions that local observations play a role.
  • Hindu and Buddist lunisolar calendars. No idea, but first-look seems simpler than Chinese due to more fixed leap rules. Except for the Burmese correction, which depends on observation.

Each of these calendar systems will likely require an external dependency with loads of tabulation, so expect discussions about optional dependencies and porting. (Even with a system as "simple and native" as Gregorian, it took some work to figure out how to find Easter!)

Dependency on observation may require updates every couple of years, and also increase the amount of data required to ship. Unless you try to predict the future. (Well, the dependency should handle it...)

@ypid ypid added the status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation. label Aug 14, 2021
@ypid
Copy link
Member

ypid commented Aug 14, 2021

I am open to external dependencies to handle that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation.
Projects
None yet
Development

No branches or pull requests

2 participants