/
ShortECDSA.java
207 lines (176 loc) · 8.23 KB
/
ShortECDSA.java
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
/*
* Copyright (c) 2021, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/
/**
* @test
* @bug 8259535
* @summary ECDSA SignatureValue do not always have the specified length
* @modules java.xml.crypto/com.sun.org.apache.xml.internal.security
* java.xml.crypto/com.sun.org.apache.xml.internal.security.signature
*/
import com.sun.org.apache.xml.internal.security.Init;
import com.sun.org.apache.xml.internal.security.signature.XMLSignature;
import org.w3c.dom.Document;
import org.w3c.dom.NodeList;
import org.xml.sax.InputSource;
import javax.xml.crypto.dsig.*;
import javax.xml.crypto.dsig.dom.DOMSignContext;
import javax.xml.crypto.dsig.keyinfo.KeyInfo;
import javax.xml.crypto.dsig.keyinfo.KeyInfoFactory;
import javax.xml.crypto.dsig.keyinfo.X509Data;
import javax.xml.crypto.dsig.keyinfo.X509IssuerSerial;
import javax.xml.crypto.dsig.spec.C14NMethodParameterSpec;
import javax.xml.crypto.dsig.spec.TransformParameterSpec;
import javax.xml.parsers.DocumentBuilderFactory;
import javax.xml.transform.TransformerFactory;
import javax.xml.transform.dom.DOMResult;
import javax.xml.transform.dom.DOMSource;
import java.io.StringReader;
import java.math.BigInteger;
import java.security.Provider;
import java.security.Security;
import java.security.*;
import java.security.spec.AlgorithmParameterSpec;
import java.security.spec.PKCS8EncodedKeySpec;
import java.util.*;
public class ShortECDSA {
public static final String XML = "<testXmlFile>\n"
+ "\t<element>Value</element>\n"
+ "</testXmlFile>";
private static final String PRIVATE_KEY_BASE_64 =
"MIGHAgEAMBMGByqGSM49AgEGCCqGSM49AwEHBG0wawIBAQQgP6yNCRsISznuzY4D"
+ "0cwkBjgV8uu2lQ2tCPxdam7Fx9OhRANCAAS33BazN06tOnXsLYatPvmkrEVDyRWj"
+ "yzxlCU+en8PPJ4ETUGRhz8h1fAELEkKS0Cky5M61oQVyiSxHaXhunH29";
private static final XMLSignatureFactory FAC =
XMLSignatureFactory.getInstance("DOM");
public static void main(String[] args) throws Exception {
DocumentBuilderFactory factory = DocumentBuilderFactory.newInstance();
factory.setNamespaceAware(true);
Document document = factory.newDocumentBuilder().
parse(new InputSource(new StringReader(XML)));
PKCS8EncodedKeySpec keySpec = new PKCS8EncodedKeySpec(
Base64.getDecoder().decode(PRIVATE_KEY_BASE_64));
KeyFactory kf = KeyFactory.getInstance("EC");
PrivateKey privateKey = kf.generatePrivate(keySpec);
// Remove SunEC so neither its ASN.1 or P1363 format ECDSA will be used
Security.removeProvider("SunEC");
Security.addProvider(new MyProvider());
Document signedDocument = XmlSigningUtils.signDocument(document, privateKey);
NodeList nodeList = signedDocument.getElementsByTagName("SignatureValue");
byte[] sig = Base64.getMimeDecoder().decode(
nodeList.item(0).getFirstChild().getNodeValue());
if (sig.length != 64) {
System.out.println("Length: " + sig.length);
System.out.println(HexFormat.ofDelimiter(":").formatHex(sig));
throw new RuntimeException("Failed");
}
// Internal way
Init.init();
XMLSignature signature = new XMLSignature(document, null,
SignatureMethod.ECDSA_SHA256, CanonicalizationMethod.INCLUSIVE);
signature.sign(privateKey);
sig = signature.getSignatureValue();
if (sig.length != 64) {
System.out.println("Length: " + sig.length);
System.out.println(HexFormat.ofDelimiter(":").formatHex(sig));
throw new RuntimeException("Failed");
}
}
public static class XmlSigningUtils {
public static Document signDocument(Document document, PrivateKey privateKey)
throws Exception {
DOMResult result = new DOMResult();
TransformerFactory.newInstance().newTransformer()
.transform(new DOMSource(document), result);
Document newDocument = (Document) result.getNode();
FAC.newXMLSignature(buildSignedInfo(), buildKeyInfo())
.sign(new DOMSignContext(privateKey, newDocument.getDocumentElement()));
return newDocument;
}
private static SignedInfo buildSignedInfo()
throws NoSuchAlgorithmException, InvalidAlgorithmParameterException {
return FAC.newSignedInfo(
FAC.newCanonicalizationMethod(CanonicalizationMethod.EXCLUSIVE, (C14NMethodParameterSpec) null),
FAC.newSignatureMethod(SignatureMethod.ECDSA_SHA256, null),
List.of(FAC.newReference(
"",
FAC.newDigestMethod(DigestMethod.SHA256, null),
List.of(FAC.newTransform(Transform.ENVELOPED, (TransformParameterSpec) null)), null, null)));
}
private static KeyInfo buildKeyInfo() {
KeyInfoFactory keyInfoFactory = FAC.getKeyInfoFactory();
X509IssuerSerial x509IssuerSerial = keyInfoFactory
.newX509IssuerSerial("CN=Me", BigInteger.ONE);
X509Data x509Data = keyInfoFactory.newX509Data(Collections.singletonList(x509IssuerSerial));
return keyInfoFactory.newKeyInfo(Collections.singletonList(x509Data));
}
}
// Only provide SHA256withECDSA, no P1363 format. This triggers the convertASN1toXMLDSIG translation.
public static class MyProvider extends Provider {
MyProvider() {
super("MyProvider", "1", "My provider");
put("Signature.SHA256withECDSA", MyECDSA.class.getName());
}
}
public static class MyECDSA extends SignatureSpi {
// Hardcoded signature with short r and s
public static byte[] hardcoded;
static {
hardcoded = new byte[68];
// Fill in with a number <128 so it will look like a
// correct ASN.1 encoding for positive numbers.
Arrays.fill(hardcoded, (byte) 0x55);
hardcoded[0] = 0x30; // SEQUENCE OF
hardcoded[1] = 66; // 2 [tag,len,31] components
hardcoded[2] = hardcoded[35] = 2; // Each being an INTEGER...
hardcoded[3] = hardcoded[36] = 31; // ... of 31 bytes long
}
protected void engineInitVerify(PublicKey publicKey) {
}
protected void engineInitSign(PrivateKey privateKey) {
}
protected void engineUpdate(byte b) {
}
protected void engineUpdate(byte[] b, int off, int len) {
}
protected byte[] engineSign() {
return hardcoded;
}
protected boolean engineVerify(byte[] sigBytes) {
return false;
}
protected void engineSetParameter(String param, Object value) {
}
protected Object engineGetParameter(String param) {
throw new UnsupportedOperationException();
}
protected void engineSetParameter(AlgorithmParameterSpec params) {
}
protected AlgorithmParameters engineGetParameters() {
throw new UnsupportedOperationException();
}
protected int engineSign(byte[] outbuf, int offset, int len) {
System.arraycopy(hardcoded, 0, outbuf, offset, hardcoded.length);
return hardcoded.length;
}
}
}