8299425: "LCMSImageLayout.isIntPacked" flag can be deleted

[mrserb]

After this change we will set correct pixel formatter when we initially create it, instead of updating the pixel formatter in native based on additional "isIntPacked" flag.

FYI: The fix for https://bugs.openjdk.org/browse/JDK-7124245 added the "isIntPacked" flag to mark the non-byte pixels layouts(like TYPE_INT_RGB).

• This flag is passed around even if it is not used by the pixel layout
• It may cause unnecessary creation of new transform if one type is "rgb && isIntPacked=true" and another one is "bgr && isIntPacked=false", but the actual data is the same
  see: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/2cf07dbdee64

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8299425: "LCMSImageLayout.isIntPacked" flag can be deleted

Reviewers

• Phil Race (@prrace - Reviewer) ⚠️ Review applies to fe57bc1e

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11806/head:pull/11806
$ git checkout pull/11806

Update a local copy of the PR:
$ git checkout pull/11806
$ git pull https://git.openjdk.org/jdk pull/11806/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11806

View PR using the GUI difftool:
$ git pr show -t 11806

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11806.diff

[bridgekeeper]

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mrserb The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full (859392bb)
• 00: Full (fe57bc1e)

[openjdk]

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8299425: "LCMSImageLayout.isIntPacked" flag can be deleted

Reviewed-by: prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• 88f0ea7: 8299726: [cleanup] Some code cleanup in opto/compile.hpp
• 0234f81: 8298447: Unnecessary Vector usage in DocPrintJob implementations
• cc4936a: 8298720: Insufficient error handling when CodeBuffer is exhausted

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mrserb]

/integrate

[openjdk]

Going to push as commit 4a95c74.
Since your change was applied there have been 11 commits pushed to the master branch:

• d6d6eb4: 8299699: Test runtime/cds/appcds/WrongClasspath.java fails after JDK-8299329
• 8c70bf3: 8299544: Improve performance of CRC32C intrinsics (non-AVX-512) for small inputs
• d6e9f01: 8285416: [LOOM] Some nsk/jdi tests fail due to needing too many virtual threads
• ba03f42: 8299746: Accept unknown signatureAlgorithm in PKCS7 SignerInfo
• 3dcf700: 8299336: InputStream::DEFAULT_BUFFER_SIZE should be 16384
• 1e99729: 8299274: Add elements to resolved_references consistently
• 8cc1669: 8299721: [Vector API] assert in switch-default of LibraryCallKit::arch_supports_vector_rotate is too weak to catch bugs
• 5598acc: 8294403: [REDO] make test should report only on executed tests
• 88f0ea7: 8299726: [cleanup] Some code cleanup in opto/compile.hpp
• 0234f81: 8298447: Unnecessary Vector usage in DocPrintJob implementations
• ... and 1 more: https://git.openjdk.org/jdk/compare/b5b7948d9b4870d9e84ec8d8b544b252f9053785...master

Your commit was automatically rebased without conflicts.

[openjdk]

@mrserb Pushed as commit 4a95c74.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.