7903129: jextract does not handle @argfile

[sundararajana]

Missed CommandLine.parse call in JextractTool.run method.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• CODETOOLS-7903129: jextract does not handle @argfile

Reviewers

• Maurizio Cimadamore (@mcimadamore - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jextract pull/4/head:pull/4
$ git checkout pull/4

Update a local copy of the PR:
$ git checkout pull/4
$ git pull https://git.openjdk.java.net/jextract pull/4/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4

View PR using the GUI difftool:
$ git pr show -t 4

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jextract/pull/4.diff

[bridgekeeper]

👋 Welcome back sundar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@sundararajana This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

7903129: jextract does not handle @argfile

Reviewed-by: mcimadamore

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mcimadamore) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[mlbridge]

Webrevs

• 02: Full - Incremental (950cb6b1)
• 01: Full - Incremental (9f4cf3c6)
• 00: Full (b0d4e0a0)

[mcimadamore]

Can the error only occur because of arg file?

[sundararajana]

Yes. CommandLine.parse

 * @throws IOException if there is a problem reading any of the @files

[mcimadamore]

Looks good - we should probably add a test for this, using tool provider

[sundararajana]

/integrate

[openjdk]

@sundararajana
Your change (at version 950cb6b) is now ready to be sponsored by a Committer.

[mcimadamore]

/integrate

[mcimadamore]

/sponsor

[openjdk]

@mcimadamore Only the author (@sundararajana) is allowed to issue the integrate command. As this pull request is ready to be sponsored, and you are an eligible sponsor, did you mean to issue the /sponsor command?

[openjdk]

Going to push as commit 60978d2.

[openjdk]

@mcimadamore @sundararajana Pushed as commit 60978d2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[mlbridge]

Mailing list message from Sundararajan Athijegannathan on jextract-dev:

Hi,

Fix has been integrated.

Please check @argfile support.

Thanks for reporting this issue,
-Sundar
________________________________
From: jextract-dev <jextract-dev-retn at openjdk.java.net> on behalf of Athijegannathan Sundararajan <sundar at openjdk.java.net>
Sent: 25 March 2022 16:16
To: jextract-dev at openjdk.java.net <jextract-dev at openjdk.java.net>
Subject: Integrated: 7903129: jextract does not handle @argfile

On Thu, 24 Mar 2022 16:59:40 GMT, Athijegannathan Sundararajan <sundar at openjdk.org> wrote:

Missed CommandLine.parse call in JextractTool.run method.

This pull request has now been integrated.

Changeset: 60978d2
Author: Athijegannathan Sundararajan <sundar at openjdk.org>
Committer: Maurizio Cimadamore <mcimadamore at openjdk.org>
URL: https://git.openjdk.java.net/jextract/commit/60978d2fa669faca0249df120dc4a55d15cdff97
Stats: 36 lines in 4 files changed: 36 ins; 0 del; 0 mod

7903129: jextract does not handle @argfile

Reviewed-by: mcimadamore

-------------

PR: https://git.openjdk.java.net/jextract/pull/4