New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add section on pre-built binaries to README #84
Conversation
Add section on pre-built binaries and move section on building to the bottom
👋 Welcome back jvernee! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
README.md
Outdated
> | ||
> Over time, new branches will be added, each targeting a specific JDK version. | ||
> </details> | ||
Pre-built binaries for jextract are peridodically released here: https://jdk.java.net/jextract/. These binaries are built from the `master` branch of this repo, and generally target the foreign memory access and function API in the latest mainline JDK (for which binaries can also be found on [jdk.java.net](https://jdk.java.net)). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could https://jdk.java.net/jextract/ be a link?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
peridodically spelling
@JornVernee This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@sundararajana) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
Webrevs
|
@JornVernee |
Co-authored-by: Maurizio Cimadamore <54672762+mcimadamore@users.noreply.github.com>
/integrate |
@JornVernee |
/sponsor |
Going to push as commit f70e8d2. |
@mcimadamore @JornVernee Pushed as commit f70e8d2. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
I've added a short section on where to find the pre-built binaries. I think building jextract is less important than the information on usage if people can get binaries, so I've moved the section on building and testing to the bottom.
Progress
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jextract pull/84/head:pull/84
$ git checkout pull/84
Update a local copy of the PR:
$ git checkout pull/84
$ git pull https://git.openjdk.org/jextract pull/84/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 84
View PR using the GUI difftool:
$ git pr show -t 84
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jextract/pull/84.diff