Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add section on pre-built binaries to README #84

Closed
wants to merge 4 commits into from

Conversation

JornVernee
Copy link
Member

@JornVernee JornVernee commented Oct 7, 2022

I've added a short section on where to find the pre-built binaries. I think building jextract is less important than the information on usage if people can get binaries, so I've moved the section on building and testing to the bottom.


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed (no review required)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jextract pull/84/head:pull/84
$ git checkout pull/84

Update a local copy of the PR:
$ git checkout pull/84
$ git pull https://git.openjdk.org/jextract pull/84/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 84

View PR using the GUI difftool:
$ git pr show -t 84

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jextract/pull/84.diff

Add section on pre-built binaries and move section on building to the bottom
@JornVernee JornVernee changed the title Add section on pre-built binaries Add section on pre-built binaries to README Oct 7, 2022
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 7, 2022

👋 Welcome back jvernee! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Copy link
Member

@sundararajana sundararajana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

README.md Outdated
>
> Over time, new branches will be added, each targeting a specific JDK version.
> </details>
Pre-built binaries for jextract are peridodically released here: https://jdk.java.net/jextract/. These binaries are built from the `master` branch of this repo, and generally target the foreign memory access and function API in the latest mainline JDK (for which binaries can also be found on [jdk.java.net](https://jdk.java.net)).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

peridodically spelling

@openjdk
Copy link

openjdk bot commented Oct 7, 2022

@JornVernee This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

Add section on pre-built binaries to README

Reviewed-by: sundar

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@sundararajana) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 7, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 7, 2022
@JornVernee
Copy link
Member Author

/integrate

@mlbridge
Copy link

mlbridge bot commented Oct 7, 2022

Webrevs

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 7, 2022
@openjdk
Copy link

openjdk bot commented Oct 7, 2022

@JornVernee
Your change (at version 4a8f808) is now ready to be sponsored by a Committer.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Co-authored-by: Maurizio Cimadamore <54672762+mcimadamore@users.noreply.github.com>
@openjdk openjdk bot removed the sponsor Pull request is ready to be sponsored label Oct 9, 2022
@JornVernee
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 10, 2022
@openjdk
Copy link

openjdk bot commented Oct 10, 2022

@JornVernee
Your change (at version 1ba7f75) is now ready to be sponsored by a Committer.

@mcimadamore
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 11, 2022

Going to push as commit f70e8d2.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 11, 2022
@openjdk openjdk bot closed this Oct 11, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 11, 2022
@openjdk
Copy link

openjdk bot commented Oct 11, 2022

@mcimadamore @JornVernee Pushed as commit f70e8d2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
3 participants