8244142: some hotspot/runtime tests don't check exit code of forked JVM

Reviewed-by: gziemski, minqi
openjdk · Apr 30, 2020 · bcf3ae8 · bcf3ae8
1 parent 47c30db
commit bcf3ae8
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/test/hotspot/jtreg/runtime/Metaspace/MaxMetaspaceSizeTest.java b/test/hotspot/jtreg/runtime/Metaspace/MaxMetaspaceSizeTest.java
@@ -43,5 +43,6 @@ public static void main(String... args) throws Exception {
             "--version");
         OutputAnalyzer output = new OutputAnalyzer(pb.start());
         output.shouldContain("MaxMetaspaceSize is too small.");
+        output.shouldNotHaveExitValue(0);
     }
 }
diff --git a/test/hotspot/jtreg/runtime/getSysPackage/GetPackageXbootclasspath.java b/test/hotspot/jtreg/runtime/getSysPackage/GetPackageXbootclasspath.java
@@ -54,6 +54,7 @@ public static void main(String args[]) throws Exception {
 
         new OutputAnalyzer(ProcessTools.createJavaProcessBuilder(
                 "-Xbootclasspath/a:" + test_classes, "P.Test")
-            .start()).shouldContain("Test Passed");
+            .start()).shouldContain("Test Passed")
+            .shouldHaveExitValue(0);
     }
 }
diff --git a/test/hotspot/jtreg/runtime/records/RedefineRecord.java b/test/hotspot/jtreg/runtime/records/RedefineRecord.java
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2019, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2019, 2020, Oracle and/or its affiliates. All rights reserved.
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * This code is free software; you can redistribute it and/or modify it
@@ -103,6 +103,7 @@ public static void main(String argv[]) throws Exception {
                 "RedefineRecord");
             OutputAnalyzer output = new OutputAnalyzer(pb.start());
             output.shouldNotContain("processing of -javaagent failed");
+            output.shouldHaveExitValue(0);
         }
     }
 }