Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: Planet_LB: Lattice-Boltzmann solutions for planetary geodynamics problems #201

Closed
whedon opened this issue Mar 13, 2023 · 25 comments

Comments

@whedon
Copy link

whedon commented Mar 13, 2023

Submitting author: @thecraigoneill (Craig O'Neill)
Repository: https://github.com/thecraigoneill/planet_LB
Version: v1.0.0
Editor: @nicoguaro
Reviewers: @brmather, @jfpa
Managing EiC: Lorena Barba

⚠️ JOSE reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSE is currently operating in a "reduced service mode".

Status

status

Status badge code:

HTML: <a href="https://jose.theoj.org/papers/483df4a80d8cb5d9e3fd5a6d9d7fa136"><img src="https://jose.theoj.org/papers/483df4a80d8cb5d9e3fd5a6d9d7fa136/status.svg"></a>
Markdown: [![status](https://jose.theoj.org/papers/483df4a80d8cb5d9e3fd5a6d9d7fa136/status.svg)](https://jose.theoj.org/papers/483df4a80d8cb5d9e3fd5a6d9d7fa136)

Author instructions

Thanks for submitting your paper to JOSE @thecraigoneill. Currently, there isn't an JOSE editor assigned to your paper.

@thecraigoneill if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSE and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSE submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented Mar 13, 2023

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

⚠️ JOSE reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSE is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Mar 13, 2023

Wordcount for paper.md is 1041

@whedon
Copy link
Author

whedon commented Mar 13, 2023

Software report (experimental):

github.com/AlDanial/cloc v 1.88  T=0.07 s (183.1 files/s, 44699.8 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                           4            121             94            568
Jupyter Notebook                 5              0           1704            508
Markdown                         2             33              0             56
TeX                              1              4              0             47
YAML                             1              6              4             29
-------------------------------------------------------------------------------
SUM:                            13            164           1802           1208
-------------------------------------------------------------------------------


Statistical information for the repository '1981966cc44a824318e9cbaa' was
gathered on 2023/03/13.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
Craig O'Neill                    6            70             14           10.26
thecraigoneill                   3           731              4           89.74

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
Craig O'Neill                56           80.0          0.6               10.71
thecraigoneill              727           99.5          4.6               12.10

@whedon
Copy link
Author

whedon commented Mar 13, 2023

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@whedon
Copy link
Author

whedon commented Mar 13, 2023

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1007/978-1-4471-7423-3 is OK
- 10.1016/j.pepi.2007.06.009 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@labarba
Copy link
Member

labarba commented Mar 13, 2023

@thecraigoneill – your paper has a lot of issues with references, and also the figure needs size adjustment. Please make this fixes, and when done you can run the command @whedon generate pdf alone in a comment here.

To make intermediate tests of the paper compilation, you can use https://whedon.theoj.org

@thecraigoneill
Copy link

Potential reviewer is https://github.com/brmather
Ben has published with JOSS and is familiar with the process, and this code.
C

@thecraigoneill
Copy link

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Mar 13, 2023

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@thecraigoneill
Copy link

@labarba formatting issues are fixed.

@labarba
Copy link
Member

labarba commented Mar 29, 2023

@nicoguaro — could you have a look at this submission, and let me know if you might be willing to edit it?
It would be your first assignment since joining the board just a few days ago, so I'll be here to help you each step of the way!
Let me know...
Title: Planet_LB: Lattice-Boltzmann solutions for planetary geodynamics problems
Repo: https://github.com/thecraigoneill/planet_LB
View article proof on GitHub

@nicoguaro
Copy link

@labarba, yes, I am willing to edit this submission.

@labarba
Copy link
Member

labarba commented Mar 30, 2023

@whedon assign @nicoguaro as editor

@whedon
Copy link
Author

whedon commented Mar 30, 2023

OK, the editor is @nicoguaro

@nicoguaro
Copy link

@brmather, @lheagy, would you be interested in reviewing this submission for JOSE? It concerns a Python package for 2D geodynamics using a lattice Boltzmann approach.

@lheagy
Copy link
Member

lheagy commented Apr 4, 2023

Thanks for reaching out! I am sorry, but I don't have time at the moment to take on this review

@brmather
Copy link

Sure, @nicoguaro I would be happy to provide a review.

@nicoguaro
Copy link

@whedon add @brmather as reviewer

@whedon
Copy link
Author

whedon commented Apr 11, 2023

OK, @brmather is now a reviewer

@nicoguaro
Copy link

@jfpa, would you be interested in reviewing this submission for JOSE? It concerns a Python package for 2D geodynamics using a lattice Boltzmann approach.

@jfpa
Copy link

jfpa commented Apr 16, 2023

yes, please count me in.

@nicoguaro
Copy link

@whedon add @jfpa as reviewer

@whedon whedon assigned brmather, jfpa and nicoguaro and unassigned nicoguaro and brmather Apr 17, 2023
@whedon
Copy link
Author

whedon commented Apr 17, 2023

OK, @jfpa is now a reviewer

@nicoguaro
Copy link

@whedon start review

@whedon
Copy link
Author

whedon commented Apr 17, 2023

OK, I've started the review over in #205.

@whedon whedon closed this as completed Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants