-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: SkyPortal: An Astronomical Data Platform #1247
Comments
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @gnarayan it looks like you're currently assigned as the reviewer for this paper 🎉. ⭐ Important ⭐ If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿 To fix this do the following two things:
For a list of things I can do to help you, just type:
|
|
@gnarayan - please carry out your review in this issue by updating the checklist above and giving feedback in this issue. The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html Any questions/concerns please let me know. |
Thank you for reviewing, @gnarayan—much appreciated! |
👋 @gnarayan - how are you getting along here? |
Had issues with the installation that it took STScI IT to help resolve, so got stuck at that point on checklist above. That's been worked through, and I've made notes on the draft, so will send something out either late tonight or tomorrow. I will say that I am at Berekely and got to meet with @stefanv and see the system being demoed, and that has been valuable. |
I've included a PDF with the review detailing the major issues to address, together with logfiles with the output from stdout and stderr on running The issues are not with the paper, or the software itself (which I thank @stefanv for demonstrating live - that always involves some risk). Rather they arise because the default installation does not demonstrate functionality (either because of a bug or because it was never designed to) and the because the current documentation isn't adequate. I hope the authors will address these, as the system as demonstrated looked very promising. |
Thanks for the review, @gnarayan! I will address the issues you mentioned and report back here. |
@whedon generate pdf |
|
@gnarayan @arfon We believe we have now addressed all of the issues identified in the first round of review. Please see skyportal/skyportal#127. Specifically, we hope that the improved logging, installation instructions, and working Docker images will aid in evaluating the paper. Feel free to let us know if there are any other issues we should address. |
The authors have addressed all my comments more than satisfactorily. They have met all the requirements laid out by JOSS. I've found one issue that occurs intermittently:
Restarting the server seems to address the issue, at least for a time. I think this is best dealt with as a github issue for skyportal, and I will raise it there. This does not count as an impediment for publication - no software is ever just "done." My compliments to the authors on this valuable contribution to the time-domain science ecosystem. |
@whedon generate pdf |
|
@whedon accept |
No archive DOI set. Exiting... |
@stefanv - At this point could you make an archive of the reviewed software in Zenodo/figshare/other service and update this thread with the DOI of the archive? I can then move forward with accepting the submission. |
@arfon I've tagged v0.9 of the software and published it as http://doi.org/10.5281/zenodo.2742377 |
@whedon set 10.5281/zenodo.2742377 as archive |
OK. 10.5281/zenodo.2742377 is the archive. |
@whedon accept |
|
|
Check final proof 👉 openjournals/joss-papers#679 If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#679, then you can now move forward with accepting the submission by compiling again with the flag
|
@whedon accept deposit=true |
|
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? notify your editorial technical team... |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
A very different way of doing reviews, and I really love the use of whedon to manage the process. Thanks for asking me to do this, @arfon! |
Submitting author: @stefanv (Stéfan van der Walt)
Repository: https://github.com/skyportal/skyportal
Version: 1.0
Editor: @arfon
Reviewer: @gnarayan
Archive: 10.5281/zenodo.2742377
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@gnarayan, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.theoj.org/about#reviewer_guidelines. Any questions/concerns please let @arfon know.
✨ Please try and complete your review in the next two weeks ✨
Review checklist for @gnarayan
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
paper.md
file include a list of authors with their affiliations?The text was updated successfully, but these errors were encountered: