[REVIEW]: resampy: efficient sample rate conversion in Python

[whedon]

Submitting author: @bmcfee (Brian McFee)
Repository: https://github.com/bmcfee/resampy
Version: 0.1.4
Editor: @arfon
Reviewer: @arokem
Archive: 10.5281/zenodo.192679

Status

Status badge code:

HTML: <a href="http://joss.theoj.org/papers/5edc41d8387010ad062c29a6a313f740"><img src="http://joss.theoj.org/papers/5edc41d8387010ad062c29a6a313f740/status.svg"></a>
Markdown: [![status](http://joss.theoj.org/papers/5edc41d8387010ad062c29a6a313f740/status.svg)](http://joss.theoj.org/papers/5edc41d8387010ad062c29a6a313f740)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer questions

Conflict of interest

• As the reviewer I confirm that there are no conflicts of interest for me to review this work (such as being a major contributor to the software).

General checks

• Repository: Is the source code for this software available at the repository url?
• License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
• Version: Does the release version given match the GitHub release (0.1.4)?
• Authorship: Has the submitting author (bmcfee) made major contributions to the software?

Functionality

• Installation: Does installation proceed as outlined in the documentation?
• Functionality: Have the functional claims of the software been confirmed?
• Performance: Have any performance claims of the software been confirmed?

Documentation

• A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
• Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
• Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
• Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g. API method documentation)?
• Automated tests: Are there automated tests or manual steps described so that the function of the software can be verified?
• Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

• Authors: Does the paper.md file include a list of authors with their affiliations?
• A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
• References: Do all archival references that should have a DOI list one (e.g. papers, datasets, software)?

[whedon]

Hello human, I'm @whedon. I'm here to help you with some common editorial tasks for JOSS.

For a list of things I can do to help you, just type:

@whedon commands

[arfon]

👋 @arokem - many thanks for agreeing to review this. This is the main review issue - please work through the checklist as you progress and let me know if you run into any difficulties.

[arokem]

👍 from me for publication.

See:

bmcfee/resampy#37
bmcfee/resampy#38
bmcfee/resampy#39
bmcfee/resampy#40
bmcfee/resampy#41

[arfon]

👍 from me for publication.

⚡️ many thanks @arokem.

@bmcfee - At this point could you make an archive of the reviewed software in Zenodo/figshare/other service and update this thread with the DOI of the archive? I can then move forward with accepting the submission.

[bmcfee]

@arfon here it is: https://zenodo.org/record/192679

Thanks!

[arfon]

@whedon set 10.5281/zenodo.192679 as archive

[whedon]

OK. 10.5281/zenodo.192679 is the archive.

[arfon]

@arokem many thanks for the review here!

@bmcfee - your paper is now accepted into JOSS and your DOI is http://dx.doi.org/10.21105/joss.00125 🚀 🎉 💥

[bmcfee]

Thanks again, @arfon and @arokem (and you too, @whedon 🤖)!