Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
[REVIEW]: TextWiller: collection of text mining utilities, specially devoted to the Italian language #1256
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@timClicks, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
Review checklist for @timClicks
Conflict of interest
Code of Conduct
If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews
To fix this do the following two things:
For a list of things I can do to help you, just type:
Copying from the pre-review thread from @timClicks :
Hi @scan2001, thanks for the paper submission. I'm not officially an assigned reviewer, but I've taken a quick look at the paper.
Let me start by saying that it's excellent to see NLP contributions to non-English languages.
However, there are many text mining packages available, even sticking within the R community. I wonder if you should cite some of the other open source NLP packages and explain that they do not offer Italian stemming/normalisation?
From the review guidelines:
Also, from the contribution list, it's unclear what level of contribution that your first author has made? (I assume that some of the commit history has been lost)
Here is the relevant guidance from the review guidelines:
TextWiller's API documentation is in Italian. However, it looks comprehensive.
(Deferring to @mgymrek for an opinion about whether this is allowed)
TextWiller doesn't appear to have a comprehensive test suite.
Note twitter discussion thread: https://twitter.com/LorenaABarba/status/1131222830794903552
Statement of need from paper.md, l 32
Here are some things you can ask me to do:
@scan2001. I agree with these comments. Including tests and community guidelines is a JOSS requirement. Are you able to add tests for TextWiller functionality, and also to expand the README with guidelines for community members to contribute or get support?
You may look at other JOSS submissions for examples. e.g. https://github.com/ropensci/citesdb
Thanks @mgymrek. We named the release v1.0 because it's the first release we did specifically for the Zenodo archive, while version 2.0 doesn't concern the release, it was only written by one collaborator in the description without any particular reason, actually we don't have 2 version of this software.
Here's what you must now do:
Any issues? notify your editorial technical team...
If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation:
We need your help!
Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following: