-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: Generic reinforcement learning codebase in TensorFlow #1524
Comments
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @desilinguist, @paragkulkarni11 it looks like you're currently assigned to review this paper 🎉. ⭐ Important ⭐ If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿 To fix this do the following two things:
For a list of things I can do to help you, just type:
|
|
@desilinguist @paragkulkarni11 Thank you for agreeing to review this submission. Whedon generated a checklist for you above. Please let me know if you have any questions or comments! |
@alexanderimanicowenrivers Thank you for helping me find reviewers. I really appreciate it. Do you mind addressing the comments by @cervere (in #1502) in the manuscript (doesn't have to be long)? |
Thanks for agreeing to review, and I have already addressed these comments @mbobra in my reply here #1502 (comment) |
👋 @desilinguist, @paragkulkarni11 How is it going? Would you like more time to review? Do you have any questions? Please let me know! |
Let me know if there is anything you would like clarified! @desilinguist @paragkulkarni11 |
Yes, I’d like until next Friday (7/12) please. |
@desilinguist Absolutely. Thanks for your time. |
Thank you :) |
Looking forward to receiving the reviews :) @desilinguist and @paragkulkarni11 |
Hi, |
I have completed my review and I think while the goal of the project is admirable – providing a generic codebase for reinforcement learning in Tensorflow that also provides nice logging and visualization features – the setup process and the overall documentation both leave a lot to be desired. I have filed two issues with suggestions on how to address both of these. The software paper does have a bit of motivation but it isn't really clear what the target demographic is - is it RL researchers who are already experts and this is a way for them to run experiments or are novice users also included? I got the impression from my interaction with the authors that it was the latter but I was quite lost. There also doesn't seem to be any real tests - the Travis CI script just runs a bunch of python |
👋 @alexanderimanicowenrivers Can you please address the comments by @paragkulkarni11 and @desilinguist? Please let me know if you want any help with this. |
Thanks for the reviews @desilinguist and @paragkulkarni11 @desilinguist - We have resolved and one issue -- an improved initialisation script. We are indeed targetting the RL researcher, rather than a novice. We are finishing up the providing clearer documentation with working examples task (as is also shown in our newer paper.md file). The idea is for this codebase to be used specifically for RL research, rather than for industrial systems (although it could be used for this too)!. @paragkulkarni11 - Thanks for the feedback, as mentioned above we have addressed the issues of working example and clearer documentation. We have been using it for research, however, we haven’t published anything yet. The reason our tests are just run scripts is due to the high stochasticity of experiments. However, we are working on developing deterministic settings which we can rigorously test. We are awaiting adding in a few more tests on the non-stochastic components. As well as finishing up the docs. Thanks! Alex and the For.ai team :) |
@desilinguist @paragkulkarni11 Do you recommend this paper for publication after @alexanderimanicowenrivers' improvements or are there still some outstanding issues? I see that the checklists are not complete and I would like some guidance on how you would like to proceed from here. |
Thanks @alexanderimanicowenrivers for the modifications! Unfortunately, I am traveling to a conference outside the country today and won't be back until August 5th. I will be happy to re-review once I am back. |
Dear reviewer, We thank you for your comments and suggestions and believe we have sufficiently addressed all points. Regarding your comment on the installation script, we have added to the file Regarding your comment on additional documentation, we have added to the files Regarding your comment on tests, we have under the directory Thanks for the great feedback. |
I hope you had a nice holiday @desilinguist , I look forward to hearing back from you and @paragkulkarni11 |
@alexanderimanicowenrivers thanks so much for considering my suggestions! I think there has been great progress. However, I still see a couple of issues:
|
Dear @desilinguist, Apologies, below are the final amendments. We are just working out how to add the badge from shields.io as we speak.
Let me know what you think. Bests, |
@alexanderimanicowenrivers I think it would be better to review the changes all together after they are merged into the In any case, I looked at the first PR for
|
The major changes have now been merged, as well as the bug for macports has now been fixed in this PR - for-ai/rl#27 Thanks @desilinguist Alex |
Thanks @alexanderimanicowenrivers! It looks much, much better now. FYI, the @mbobra please consider this approved from my side! |
@openjournals/joss-eics This paper is ready for acceptance! Nice work @hsezhiyan @alexanderimanicowenrivers @bryanlimy 🎉 |
@whedon generate pdf |
|
Hi @alexanderimanicowenrivers, some fixes needed in the paper before we publish:
|
Hi Kyle, Thanks for you update! I apologize for the delayed response. I've addressed your comments in PR#32 I've fixed all issues except the Silver 2014 reference. I checked other papers on arxiv, and they cite they cite it the exact same way. Let me know if you have other concerns. |
@whedon generate pdf |
|
Hi @hsezhiyan, thanks for making those edits. I just submitted a PR that fixes two final things in the references: for-ai/rl#33
|
@kyleniemeyer thanks for the review and the pull request! I have merged your PR. Are we good to go? |
@whedon generate pdf |
|
@whedon set 10.5281/zenodo.3408453 as archive |
OK. 10.5281/zenodo.3408453 is the archive. |
@whedon accept |
|
|
Check final proof 👉 openjournals/joss-papers#1006 If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#1006, then you can now move forward with accepting the submission by compiling again with the flag
|
@whedon accept deposit=true |
|
🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? notify your editorial technical team... |
Congrats @hsezhiyan on your article's publication in JOSS! Many thanks to @desilinguist & @paragkulkarni11 for reviewing, and @mbobra for editing, this submission. |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Thank you very much @kyleniemeyer for your close collaboration at the last steps! Thank you @mbobra for your guidance! And thanks @desilinguist and @paragkulkarni11 for your reviews! |
Submitting author: @alexanderimanicowenrivers (Alexander I. Cowen-Rivers)
Repository: https://github.com/for-ai/rl
Version: 1.0.0
Editor: @mbobra
Reviewer: @desilinguist, @paragkulkarni11
Archive: 10.5281/zenodo.3408453
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@desilinguist & @paragkulkarni11, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @mbobra know.
✨ Please try and complete your review in the next two weeks ✨
Review checklist for @desilinguist
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
paper.md
file include a list of authors with their affiliations?Review checklist for @paragkulkarni11
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
paper.md
file include a list of authors with their affiliations?The text was updated successfully, but these errors were encountered: