-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: G3F: Global, Multidimensional Spectral Regression Analysis #1629
Comments
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @tcausgrove, @FaustinCarter it looks like you're currently assigned to review this paper 🎉. ⭐ Important ⭐ If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿 To fix this do the following two things:
For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
👋 @dap-biospec @tcausgrove @FaustinCarter the review takes place in here |
I'm working through the demo, starting to understand the software. I'm having two issues, which may be related. One, when I open the demo, Igor looks for a "submission_02_works:Demo" folder, which I can't find. (The folder levels in general seem off, extra ::: in front.) Also, for the Process Fitting part of the demo, I can't find the Process_SpecEChem_4Spec_ForOxd_2D function. Am I missing something? |
@tcausgrove I updated Demo_G3F.pxp and Performance_Test.pxp after your earlier message. The offending path was deleted. I recommend downloading complete repo as ZIP file to ensure that Igor experiments are current. A characteristic change is checked "Epsilon" checkbox in the main panel. Another check is Misc->"Path Status": QuantAnalysis path should be "[path_to_parent]\G3F-master\G3F". The process fitting function Process_SpecEChem_4Spec_ForOxd_2D (and others required for methods 2 and 3) in now in the updated SpecEchem_4Spec_ForOxd_2.ipf procedure file. |
@tcausgrove, @FaustinCarter - we updated the demo to exclude unnecessary path (error on load) and to use the correct demo procedure file. Thank you @tcausgrove for bringing it up. Although we tested full download from GitHub before the review, some procedures were still loaded from our network locations instead of relative location in the repo mirror. We identified the cause only after disabling the network on the testing computer. Sorry about that! Since .gitignore includes *.pxp entry, please make sure that you have the latest demo and testing experiments. Re-downloading repository as ZIP should do the trick. |
OK, the demo runs all the way through for me now. Thanks @dap-biospec for the new version. It has taken me a while to figure out how things fit together - there are quite a few moving parts to this software. The learning curve might be a bit of a barrier to adoption. There are a few things that could probably be addressed more thoroughly in the manual. For example, the items in the Analysis->Global 3D Spectral Regression menu are barely mentioned, but seem very useful. Some things that I think would be good for future releases:
This is a really extensive system for fitting multi-dimensional data. The software seems to be more or less in finished form, but the documentation could be improved as an ongoing effort. I am ready to recommend acceptance. |
Thank you, @tcausgrove. We certainly will continue to develop tutorial moving forward. We are preparing a publication where layers are instrumental for describing isotopic compositions of time-resolved vibrational spectra and we think that this would be a great context to showcase this. Much of the demo is a simple example taken out of context of our two papers cited herein. We will check for and purge unnecessary data and add a note on the context to the tutorial. Again, thank you for a speedy review! cc: @FaustinCarter |
@tcausgrove, @FaustinCarter Non-essential data were purged from the demo experiment. |
@tcausgrove, @FaustinCarter Demo experiment, description, and the manual were updated per requests by @tcausgrove: extra parameters and the post-processing function illustrations. We believe that we addressed all the issues required by the reviewers. In the absence of additional requests, we hope that the review can be completed soon. cc: @kyleniemeyer |
I don't have any specific objections to publishing this. It's a cool package, and it has a lot of functionality. However, it is a complicated enough project that I think the documentation could use some expansion; I don't think very many people will use it without some serious hand-holding in the docs. I won't hold the review up over it as long as the authors agree in good faith to take a stab at improving it, but here are my suggestions :
Finally, there are a couple of typos/missing words in the JOSS manuscript (I found one in each of the last two paragraphs, and I may have missed more) so that should get a careful readthrough before it is finalized. |
Thank you @FaustinCarter. Point is taken. You are correct - this package transpired from a high-level chemical problems that could not be solved by conventional approaches. We will continue to update documentation with more generic examples and additional scenarios. |
Thanks for your feedback @FaustinCarter! @dap-biospec please work on addressing some of those comments, and let us know when you've been able to. |
@FaustinCarter thank you for pointing out typos and omissions in the paper. They have been corrected. The section of the paper describing process fitting has been revised with examples and explanations, keeping a more general scope in mind. I like the idea of simple examples (say, a single Gaussian band with superimposed noise variable over 2D or 3D space), although its careful execution will require more time. A "general information" section has been added to the beginning of the manual. This section clearly states the algorithm used by G3F, its relationship with IgorPro engine, the source of reported confidence intervals, and the links to the IgorPro manual as the primary source of information. @FaustinCarter is correct that 3D data are internally linearized and each data point is treated independently. This is the standard approach implemented in IgorPro and, therefore, we do not elaborate on it further. I would be quite interested in exploring other algorithms in the future, including dimension-specific weighting of parameters. We hope that these changes address the critical concerns and that they would allow to move forward at this time. cc: @kyleniemeyer |
@kyleniemeyer archive has been deposited to Zenodo - DOI is 10.5281/zenodo.3377994 |
@whedon generate pdf |
|
@FaustinCarter are you satisfied by the changes made? |
I'm happy to move forward with publication. |
@whedon generate pdf |
|
@whedon generate pdf |
@whedon check references |
|
|
@whedon set 10.5281/zenodo.3377994 as archive |
I'm sorry @dap-biospec, I'm afraid I can't do that. That's something only editors are allowed to do. |
@kyleniemeyer - OK, I think I did everything I am permitted to do. I corrected minor style issue in the paper; proof looks good to me. |
@whedon set 10.5281/zenodo.3377994 as archive |
OK. 10.5281/zenodo.3377994 is the archive. |
@dap-biospec I did some copy editing to the paper and made changes in a PR: dap-biospec/G3F#2 There was an issue I couldn't resolve, in the Concept paragraph. There's something off in "obtain completely unknown difference infrared spectra", but I can't figure out what it should be. Maybe "obtain completely unknown differences in infrared spectra"? |
I think they are getting at something like "analyze a set of measurements to determine previously unknown difference spectra". It seems the object is to separate chemical species based on perhaps incomplete oxidation/reduction. JMO. |
@kyleniemeyer - merge is done. |
@whedon generate pdf |
|
OK, all looks good here now! |
@whedon accept |
|
Check final proof 👉 openjournals/joss-papers#933 If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#933, then you can now move forward with accepting the submission by compiling again with the flag
|
@whedon accept deposit=true |
|
🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? notify your editorial technical team... |
Congrats @dap-biospec on your article's publication in JOSS! Many thanks to @tcausgrove and @FaustinCarter for reviewing. |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Thank you @tcausgrove, @FaustinCarter, and @kyleniemeyer for guidance, support, and patience! It is much appreciated! |
Submitting author: @dap-biospec (Denis Proshlyakov)
Repository: https://github.com/dap-biospec/G3F
Version: v1.0a4
Editor: @kyleniemeyer
Reviewer: @tcausgrove, @FaustinCarter
Archive: 10.5281/zenodo.3377994
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@tcausgrove & @FaustinCarter, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @kyleniemeyer know.
✨ Please try and complete your review in the next two weeks ✨
Review checklist for @tcausgrove
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
paper.md
file include a list of authors with their affiliations?Review checklist for @FaustinCarter
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
paper.md
file include a list of authors with their affiliations?The text was updated successfully, but these errors were encountered: