Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW]: bíogo/hts: high throughput sequence handling for the Go language #168

Closed
16 of 17 tasks
whedon opened this issue Jan 24, 2017 · 12 comments
Closed
16 of 17 tasks
Labels
accepted published Papers published in JOSS recommend-accept Papers recommended for acceptance in JOSS. review

Comments

@whedon
Copy link

whedon commented Jan 24, 2017

Submitting author: kortschak (Robert Daniel Kortschak)
Repository: https://github.com/biogo/hts
Version: v1.0.0
Editor: @pjotrp
Reviewer: @sb10
Archive: 10.5281/zenodo.268032

Status

status

Status badge code:

HTML: <a href="http://joss.theoj.org/papers/60c0df50b88413e46d04cbbb63e42a77"><img src="http://joss.theoj.org/papers/60c0df50b88413e46d04cbbb63e42a77/status.svg"></a>
Markdown: [![status](http://joss.theoj.org/papers/60c0df50b88413e46d04cbbb63e42a77/status.svg)](http://joss.theoj.org/papers/60c0df50b88413e46d04cbbb63e42a77)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer questions

Conflict of interest

  • As the reviewer I confirm that there are no conflicts of interest for me to review this work (such as being a major contributor to the software).

General checks

  • Repository: Is the source code for this software available at the repository url?
  • License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
  • Version: Does the release version given match the GitHub release (v1.0.0)?
  • Authorship: Has the submitting author (kortschak) made major contributions to the software?

Functionality

  • Installation: Does installation proceed as outlined in the documentation?
  • Functionality: Have the functional claims of the software been confirmed?
  • Performance: Have any performance claims of the software been confirmed?

Documentation

  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
  • Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
  • Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g. API method documentation)?
  • Automated tests: Are there automated tests or manual steps described so that the function of the software can be verified?
  • Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

  • Authors: Does the paper.md file include a list of authors with their affiliations?
  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • References: Do all archival references that should have a DOI list one (e.g. papers, datasets, software)?
@whedon
Copy link
Author

whedon commented Jan 24, 2017

Hello human, I'm @whedon. I'm here to help you with some common editorial tasks for JOSS. @sb10 it looks like you're currently assigned as the reviewer for this paper 🎉.

⭐ Important ⭐

If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As as reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all JOSS reviews 😿

To fix this do the following two things:

  1. Set yourself as 'Not watching' https://github.com/openjournals/joss-reviews:

watching

  1. You may also like to change your default settings for this watching repositories in your GitHub profile here: https://github.com/settings/notifications

notifications

For a list of things I can do to help you, just type:

@whedon commands

@sb10
Copy link

sb10 commented Jan 24, 2017

@whedon commands

@whedon
Copy link
Author

whedon commented Jan 24, 2017

Here are some things you can ask me to do:

# List all of Whedon's capabilities
@whedon commands

# Assign a GitHub user as the reviewer of this submission
@whedon assign @username as reviewer

# List the GitHub usernames of the JOSS editors
@whedon list editors

# List of JOSS reviewers together with programming language preferences and domain expertise
@whedon list reviewers

# Change editorial assignment
@whedon assign @username as editor

# Set the software archive DOI at the top of the issue e.g.
@whedon set 10.0000/zenodo.00000 as archive

# Open the review issue
@whedon start review

🚧 Important 🚧

This is all quite new. Please make sure you check the top of the issue after running a @whedon command (you might also need to refresh the page to see the issue update).

@sb10
Copy link

sb10 commented Feb 1, 2017

v1.0.1 passes all of the reviewer questions and I'm satisfied with it.

@pjotrp
Copy link

pjotrp commented Feb 1, 2017

Thank you @sb10 for the review. @arfon I think we can proceed with acceptance.

@arfon
Copy link
Member

arfon commented Feb 2, 2017

Thank you @sb10 for the review. @arfon I think we can proceed with acceptance.

Great. Thanks @pjotrp and thanks to @sb10 for completing the review ⚡

@kortschak - At this point could you make an archive of the reviewed software in Zenodo/figshare/other service and update this thread with the DOI of the archive? I can then move forward with accepting the submission.

@arfon arfon added the accepted label Feb 2, 2017
@kortschak
Copy link

10.5281/zenodo.268032

Thank you.

@arfon
Copy link
Member

arfon commented Feb 4, 2017

@whedon set 10.5281/zenodo.268032 as archive

@whedon
Copy link
Author

whedon commented Feb 4, 2017

OK. 10.5281/zenodo.268032 is the archive.

@arfon
Copy link
Member

arfon commented Feb 4, 2017

@kortschak - could you please move the references in https://github.com/biogo/hts/blob/master/paper/paper.md to a separate paper.bib file and then reference them from your paper.md file. You can see an example of how to do this here: https://github.com/arfon/fidgit/tree/master/paper

@kortschak
Copy link

@arfon Done.

@arfon
Copy link
Member

arfon commented Feb 5, 2017

Many thanks @pjotrp for editing this submission and @sb10 for the review ✨

@kortschak - your paper is now accepted into JOSS and your DOI is http://dx.doi.org/10.21105/joss.00168 ⚡️ 🚀 💥

@arfon arfon closed this as completed Feb 5, 2017
@whedon whedon added published Papers published in JOSS recommend-accept Papers recommended for acceptance in JOSS. labels Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted published Papers published in JOSS recommend-accept Papers recommended for acceptance in JOSS. review
Projects
None yet
Development

No branches or pull requests

5 participants