Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: root_numpy: The interface between ROOT and NumPy #262

Closed
whedon opened this issue May 18, 2017 · 16 comments
Closed

[PRE REVIEW]: root_numpy: The interface between ROOT and NumPy #262

whedon opened this issue May 18, 2017 · 16 comments
Assignees

Comments

@whedon
Copy link

whedon commented May 18, 2017

Submitting author: @ndawe (Edmund Dawe)
Repository: https://github.com/scikit-hep/root_numpy
Version: 4.7.2
Editor: @danielskatz
Reviewer: @wlav

Author instructions

Thanks for submitting your paper to JOSS @ndawe. The JOSS editor (shown at the top of this issue) will work with you on this issue to find a reviewer for your submission before creating the main review issue.

@ndawe if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented May 18, 2017

Hello human, I'm @whedon. I'm here to help you with some common editorial tasks for JOSS. @jakevdp it looks like you're currently assigned as the editor for this paper 🎉

For a list of things I can do to help you, just type:

@whedon commands

@arfon
Copy link
Member

arfon commented Jun 14, 2017

👋 @jakevdp - are you able to handle this submission for us?

@arfon
Copy link
Member

arfon commented Jul 4, 2017

@openjournals/joss-editors - would anyone else be able to handle this submission for JOSS?

@danielskatz
Copy link

I can take it

@arfon
Copy link
Member

arfon commented Jul 4, 2017

I can take it

👍 many thanks @danielskatz

@danielskatz
Copy link

@whedon assign @danielskatz as editor

@whedon whedon assigned danielskatz and unassigned jakevdp Jul 5, 2017
@whedon
Copy link
Author

whedon commented Jul 5, 2017

OK, the editor is @danielskatz

@danielskatz
Copy link

I'm looking for reviewer volunteers now. @betatim, @jpivarski, and @wlav have all been suggested. Would one of you be willing to review this paper for JOSS? (for more info about the journal and process, see http://joss.theoj.org/about, and particularly http://joss.theoj.org/about#reviewer_guidelines)

@wlav
Copy link

wlav commented Jul 6, 2017

Sure can do, assuming that I pass the COI threshold.

@danielskatz
Copy link

@wlav
Did you contribute to the code?
What other potential COIs should we be concerned with?

@wlav
Copy link

wlav commented Jul 6, 2017

No, I did not contribute nor did I use the code. However, root_numpy uses PyROOT extensively, and I was the main developer of that. Thus, I very much like root_numpy to succeed.

@danielskatz
Copy link

I don't see any COIs then.

So I will take "Sure can do" as an accept :)
and start the review process - more notifications will follow

@danielskatz
Copy link

@whedon assign @wlav as reviewer

@whedon
Copy link
Author

whedon commented Jul 6, 2017

OK, the reviewer is @wlav

@whedon whedon assigned danielskatz and wlav and unassigned danielskatz Jul 6, 2017
@danielskatz
Copy link

@whedon start review magic-word=bananas

@whedon
Copy link
Author

whedon commented Jul 6, 2017

OK, I've started the review over in #307. Feel free to close this issue now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants