Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: PySensors: A Python Package for Sparse Sensor Placement #2785

Closed
whedon opened this issue Oct 27, 2020 · 42 comments
Closed

[PRE REVIEW]: PySensors: A Python Package for Sparse Sensor Placement #2785

whedon opened this issue Oct 27, 2020 · 42 comments

Comments

@whedon
Copy link

whedon commented Oct 27, 2020

Submitting author: @briandesilva (Brian de Silva)
Repository: https://github.com/dynamicslab/pysensors/
Version: v.0.3.0
Editor: @pdebuyl
Reviewers: @jordanperr, @tuelwer
Managing EiC: Arfon Smith

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Author instructions

Thanks for submitting your paper to JOSS @briandesilva. Currently, there isn't an JOSS editor assigned to your paper.

@briandesilva if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented Oct 27, 2020

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Oct 27, 2020

Failed to discover a Statement of need section in paper

@whedon
Copy link
Author

whedon commented Oct 27, 2020

Software report (experimental):

github.com/AlDanial/cloc v 1.84  T=0.29 s (143.0 files/s, 27858.1 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          24            533            798           1215
Jupyter Notebook                 7              0           3465            774
TeX                              1             78              0            649
reStructuredText                 3             86             61            122
YAML                             4              8              0            103
Markdown                         1             13              0             66
TOML                             1              2              0             16
-------------------------------------------------------------------------------
SUM:                            41            720           4324           2945
-------------------------------------------------------------------------------


Statistical information for the repository 'c365e0f424edc2c4ed1d7f06' was
gathered on 2020/10/27.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
briandesilva                    95          5713           3251           98.61
emilyclark012                    8           106             20            1.39

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
Brian                      2510          100.0          1.8                7.09
emilyclark012                36           34.0          3.0               16.67

@whedon whedon added the Python label Oct 27, 2020
@whedon
Copy link
Author

whedon commented Oct 27, 2020

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@whedon
Copy link
Author

whedon commented Oct 27, 2020

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1073/pnas.1517384113 is OK
- 10.1109/access.2018.2886528 is OK
- 10.1126/science.1165893 is OK
- 10.1103/physrevmaterials.2.083802 is OK
- 10.1111/j.2517-6161.1996.tb02080.x is OK
- 10.5281/zenodo.1173754 is OK
- 10.1364/oe.24.030433 is OK
- 10.1063/1.5066099 is OK
- 10.1063/1.4977057 is OK
- 10.1016/j.ymssp.2018.08.033 is OK
- 10.1126/sciadv.1602614 is OK
- 10.1098/rspa.2016.0446 is OK
- 10.1137/16m1086637 is OK
- 10.1137/18m116798x is OK
- 10.1017/jfm.2017.823 is OK
- 10.1063/1.5018409 is OK
- 10.1016/j.ifacol.2016.10.249 is OK
- 10.1103/physreve.96.023302 is OK
- 10.1016/j.jcp.2018.10.045 is OK
- 10.1098/rspa.2018.0335 is OK
- 10.1016/j.jcp.2019.07.049 is OK
- 10.1103/physreve.101.010203 is OK
- 10.1115/1.4043148 is OK

MISSING DOIs

- 10.1109/mcs.2018.2810460 may be a valid DOI for title: Data-driven sparse sensor placement for reconstruction: Demonstrating the benefits of exploiting known patterns
- 10.1017/jfm.2011.195 may be a valid DOI for title: H 2 optimal actuator and sensor placement in the linearised complex Ginzburg-Landau system
- 10.2514/6.2004-2415 may be a valid DOI for title: Unsteady flow sensing and estimation via the gappy proper orthogonal decomposition
- 10.1109/access.2020.3023625 may be a valid DOI for title: A unified sparse optimization framework to learn parsimonious physics-informed models from data
- 10.1007/s00162-020-00536-w may be a valid DOI for title: Data-driven modeling of the chaotic thermal convection in an annular thermosyphon
- 10.1016/j.ocemod.2009.01.001 may be a valid DOI for title: Efficient sensor placement for ocean measurements using low-dimensional concepts
- 10.1109/cdc.2014.7040017 may be a valid DOI for title: An ADMM algorithm for optimal sensor and actuator selection
- 10.1017/jfm.2017.137 may be a valid DOI for title: Local flow characterization using bioinspired sensory information
- 10.1073/pnas.1808909115 may be a valid DOI for title: Neural-inspired sensors enable sparse, efficient classification of spatiotemporal data
- 10.1016/j.jmsy.2018.01.011 may be a valid DOI for title: Predicting shim gaps in aircraft assembly with machine learning and sparse sensing
- 10.1017/jfm.2018.147 may be a valid DOI for title: Sparse reduced-order modeling: sensor-based dynamics to full-state estimation
- 10.1007/s00162-020-00520-4 may be a valid DOI for title: Deep model predictive flow control with limited sensor data and online learning
- 10.1002/cpa.20124 may be a valid DOI for title: Stable signal recovery from incomplete and inaccurate measurements
- 10.1016/0167-7152(84)90020-8 may be a valid DOI for title: Optimal monitoring network designs
- 10.1016/j.crma.2004.08.006 may be a valid DOI for title: An ‘empirical interpolation’method: application to efficient reduced-basis discretization of partial differential equations
- 10.1162/0899766053723032 may be a valid DOI for title: Asymptotic theory of information-theoretic experimental design
- 10.1109/tit.2006.885507 may be a valid DOI for title: Near optimal signal recovery from random projections: Universal encoding strategies?
- 10.1109/tit.2005.862083 may be a valid DOI for title: Robust uncertainty principles: exact signal reconstruction from highly incomplete frequency information
- 10.1109/tit.2009.2034811 may be a valid DOI for title: Beyond Nyquist: Efficient sampling of sparse bandlimited signals
- 10.1016/j.acha.2010.10.002 may be a valid DOI for title: Compressed sensing with coherent and redundant dictionaries
- 10.1145/1879141.1879192 may be a valid DOI for title: Estimating and Sampling Graphs with Multidimensional Random Walks
- 10.1137/090766498 may be a valid DOI for title: Nonlinear model reduction via discrete empirical interpolation
- 10.1111/j.1467-9868.2011.00783.x may be a valid DOI for title: Penalized classification using Fisher’s linear discriminant
- 10.1137/110822724 may be a valid DOI for title: A state space error estimate for POD-DEIM nonlinear model reduction
- 10.1109/tsipn.2016.2614903 may be a valid DOI for title: Signal recovery on graphs: Fundamental limits of sampling strategies
- 10.1109/sam.2016.7569707 may be a valid DOI for title: Subsampling for graph power spectrum estimation
- 10.1137/16m1081270 may be a valid DOI for title: Householder QR Factorization With Randomization for Column Pivoting (HQRRP)

INVALID DOIs

- None

@briandesilva
Copy link

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Oct 27, 2020

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@arfon
Copy link
Member

arfon commented Oct 28, 2020

Failed to discover a Statement of need section in paper

👋 @briandesilva - could you please make sure your paper has a clear statement of need for a general, non-specialist audience?

@briandesilva
Copy link

@arfon, I just added a statement of need section to the paper.

@arfon
Copy link
Member

arfon commented Oct 29, 2020

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Oct 29, 2020

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@arfon
Copy link
Member

arfon commented Oct 29, 2020

@whedon invite @drvinceknight as editor

👋 @drvinceknight - would you be able to take on this submission?

@whedon
Copy link
Author

whedon commented Oct 29, 2020

@drvinceknight has been invited to edit this submission.

@Kevin-Mattheus-Moerman
Copy link
Member

@drvinceknight @pdebuyl could one of you edit this submission?

@pdebuyl
Copy link

pdebuyl commented Nov 5, 2020

@whedon assing me as editor

@whedon
Copy link
Author

whedon commented Nov 5, 2020

I'm sorry human, I don't understand that. You can see what commands I support by typing:

@whedon commands

@pdebuyl
Copy link

pdebuyl commented Nov 5, 2020

@whedon commands

@whedon
Copy link
Author

whedon commented Nov 5, 2020

Here are some things you can ask me to do:

# List all of Whedon's capabilities
@whedon commands

# Assign a GitHub user as the sole reviewer of this submission
@whedon assign @username as reviewer

# Add a GitHub user to the reviewers of this submission
@whedon add @username as reviewer

# Re-invite a reviewer (if they can't update checklists)
@whedon re-invite @username as reviewer

# Remove a GitHub user from the reviewers of this submission
@whedon remove @username as reviewer

# List of editor GitHub usernames
@whedon list editors

# List of reviewers together with programming language preferences and domain expertise
@whedon list reviewers

# Change editorial assignment
@whedon assign @username as editor

# Set the software archive DOI at the top of the issue e.g.
@whedon set 10.0000/zenodo.00000 as archive

# Set the software version at the top of the issue e.g.
@whedon set v1.0.1 as version

# Open the review issue
@whedon start review

EDITORIAL TASKS

# All commands can be run on a non-default branch, to do this pass a custom 
# branch name by following the command with `from branch custom-branch-name`.
# For example:

# Compile the paper
@whedon generate pdf

# Compile the paper from alternative branch
@whedon generate pdf from branch custom-branch-name

# Remind an author or reviewer to return to a review after a
# certain period of time (supported units days and weeks)
@whedon remind @reviewer in 2 weeks

# Ask Whedon to do a dry run of accepting the paper and depositing with Crossref
@whedon accept

# Ask Whedon to check the references for missing DOIs
@whedon check references

# Ask Whedon to check repository statistics for the submitted software
@whedon check repository

EiC TASKS

# Invite an editor to edit a submission (sending them an email)
@whedon invite @editor as editor

# Reject a paper
@whedon reject

# Withdraw a paper
@whedon withdraw

# Ask Whedon to actually accept the paper and deposit with Crossref
@whedon accept deposit=true

@pdebuyl
Copy link

pdebuyl commented Nov 5, 2020

@whedon assign @pdebuyl as editor

@whedon
Copy link
Author

whedon commented Nov 5, 2020

OK, the editor is @pdebuyl

@pdebuyl
Copy link

pdebuyl commented Nov 5, 2020

Hi @briandesilva thank you for submitting to JOSS. I will look for reviewers shortly.

In the meantime, I have a few comments

  • The second paragraph of the article is a laundry list of citations. JOSS papers should be written for a non-specialist audience and include "a list of key references".
  • The list of author of the fourth reference is lacking full names.
  • Please also check that the DOI are properly formatted for all references.
  • You do not cite scikit-learn despite having prepared your library for interacting with it. This should be fixed.

@pdebuyl
Copy link

pdebuyl commented Nov 5, 2020

@stsievert , @jordanperr can you review the article "PySensors: A Python Package for Sparse Sensor Placement" for JOSS ?

@jordanperr
Copy link

@pdebuyl Happy to review this, but I'm not very familiar with the process. I am aware of the reviewer checklist, but It would be helpful if you could please guide me through the procedure.

@pdebuyl
Copy link

pdebuyl commented Nov 5, 2020

Thank you for the reply @jordanperr . We have documentation for authors / reviewers / editors at https://joss.readthedocs.io/en/latest/index.html

The high-level view is this: when we have two reviewers, I start the review. There will be a new github issue with the checklist and a link to the instructions. The issue page serves as the communication channel for all involved and I'll be available to reply to questions. You can have a look at accepted papers reviews if you wish https://github.com/openjournals/joss-reviews/issues?page=5&q=+label%3Aaccepted

For now, you should just wait for the review to start :-)

@briandesilva
Copy link

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Nov 6, 2020

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@briandesilva
Copy link

@pdebuyl, I just pushed the changes you requested. Please let me know if the DOIs aren't formatted the way you had in mind.

@pdebuyl
Copy link

pdebuyl commented Nov 6, 2020

Thank you @briandesilva , apart from Karniadakis 2009 and Tao the references are fine and my other comments addressed.

@stsievert
Copy link

I'll have to decline the review; I'm already on a different JOSS review and have limited bandwidth.

@briandesilva
Copy link

@whedon generate pdf

@briandesilva
Copy link

briandesilva commented Nov 7, 2020

apart from Karniadakis 2009 and Tao the references are fine and my other comments addressed.

Good catch—fixed.

@whedon
Copy link
Author

whedon commented Nov 7, 2020

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@pdebuyl
Copy link

pdebuyl commented Nov 9, 2020

Thank you @briandesilva

@pdebuyl
Copy link

pdebuyl commented Nov 9, 2020

@tuelwer can you review the article "PySensors: A Python Package for Sparse Sensor Placement" for JOSS ?

@tuelwer
Copy link

tuelwer commented Nov 9, 2020

@pdebuyl sure, I can write a review for this paper!

@pdebuyl
Copy link

pdebuyl commented Nov 9, 2020

Thank you @tuelwer

@pdebuyl
Copy link

pdebuyl commented Nov 9, 2020

@whedon assign @jordanperr as reviewer

@whedon whedon assigned jordanperr and pdebuyl and unassigned pdebuyl Nov 9, 2020
@whedon
Copy link
Author

whedon commented Nov 9, 2020

OK, @jordanperr is now a reviewer

@pdebuyl
Copy link

pdebuyl commented Nov 9, 2020

@whedon add @tuelwer as reviewer

@whedon whedon assigned jordanperr, pdebuyl and tuelwer and unassigned jordanperr and pdebuyl Nov 9, 2020
@whedon
Copy link
Author

whedon commented Nov 9, 2020

OK, @tuelwer is now a reviewer

@pdebuyl
Copy link

pdebuyl commented Nov 9, 2020

@whedon start review

@whedon
Copy link
Author

whedon commented Nov 9, 2020

OK, I've started the review over in #2828.

@whedon whedon closed this as completed Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants