-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: Coral: a parallel spectral solver for fluid dynamics and partial differential equations #2978
Comments
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @robertsawko, @rhaas80 it looks like you're currently assigned to review this paper 🎉. Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post. ⭐ Important ⭐ If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿 To fix this do the following two things:
For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
👋 @robertsawko, please update us on how your review is going. |
👋 @rhaas80, please update us on how your review is going. |
@robertsawko, @rhaas80, could you post a review update? |
comments working through installation:
|
Thank you for your comments.
|
The argument mismatch is new by gfortran. Apparently such usage was never really allowed by the Fortran standard, but also never really enforced by compilers (though you may want to give eg the Cray compiler a try which in my experience is pickier than gfortran or ifort). You are certainly not the only code tripped up by this, eg https://www.google.com/search?q=gfortran-10+allow-mismatch&ie=utf-8&oe=utf-8 . For gfortran's release announcement about the issue, please see: https://gcc.gnu.org/gcc-10/changes.html#fortran |
Thank you for these details. This feature definitely helped catching a bug which fortunately had no consequences. (Some pointers used to be twice as long as intended, but fortunately their second half was never accessed.) |
@whedon generate pdf |
@whedon generate pdf |
In "2_First_run":
where |
This seems to be due to assuming that
just before the |
Roland, I have fixed the wiki I am most grateful for your checks, comments and suggestions.
No segfault was triggered. |
Thanks @rhaas80 for your thorough comments, and @BenMql for addressing them promptly! @robertsawko, do you have any update to report at this stage? |
|
Thanks for your progress so far, @rhaas80. I can see your checklist is not complete, but your help up to this point is very appreciated. |
@BenMql - I missed one issue, which will be fixed if you merge BenMql/coral#23 (I hope) - Please merge this, and run
I can then move forward with accepting the submission. |
@whedon generate pdf |
@BenMql - you might want to change the bib entry for your J Fluid Mech paper to have your first initial rather than first name for consistency, but it's not a big deal either way |
@whedon generate pdf |
@danielskatz That looks better. The version tag is v1.1.12 |
the repo (which can but doesn't have to include the paper) should be registered as software - some people use https://guides.github.com/activities/citable-code/ and then make a tagged release on github, which creates the zenodo deposit - if you do this, you will then need to change the zenodo metadata to match the paper title and authors manually |
@danielskatz -- the archived Coral v1.1.12 has been uploaded on Zenodo and has received the DOI |
@whedon set v1.1.12 as version |
OK. v1.1.12 is the version. |
@whedon set 10.5281/zenodo.5458888 as archive |
OK. 10.5281/zenodo.5458888 is the archive. |
@whedon recommend-accept |
|
|
👋 @openjournals/joss-eics, this paper is ready to be accepted and published. Check final proof 👉 openjournals/joss-papers#2569 If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#2569, then you can now move forward with accepting the submission by compiling again with the flag
|
@whedon accept deposit=true |
|
🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
@BenMql - The DOI doesn't yet resolve for me - when it does, I will close this issue and we'll be done. |
Fantastic. Thank you for your assistance. |
Congratulations to @BenMql (BENJAMIN MIQUEL)!! (The DOI is now working, so we're done) And thanks to @eloisabentivegna for editing, and @robertsawko and @rhaas80 for reviewing! |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @BenMql (BENJAMIN MIQUEL)
Repository: https://github.com/BenMql/coral
Version: v1.1.12
Editor: @eloisabentivegna
Reviewer: @robertsawko, @rhaas80
Archive: 10.5281/zenodo.5458888
Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@robertsawko & @rhaas80, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @eloisabentivegna know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Review checklist for @robertsawko
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
Review checklist for @rhaas80
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
The text was updated successfully, but these errors were encountered: