[PRE REVIEW]: New developments in PySDM and PySDM-examples v2: collisional breakup, immersion freezing, dry aerosol composition initialisation, and adaptive time-stepping #4412

editorialbot · 2022-05-21T16:50:43Z

Submitting author: @edejong-caltech (Emily de Jong)
Repository: https://github.com/atmos-cloud-sim-uj/PySDM
Branch with paper.md (empty if default branch):
Version: v2.8
Editor: @dhhagan
Reviewers: @douglowe, @emmasimp
Managing EiC: Kevin M. Moerman

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/5110170dd97fe1ebf08227881f76bda9"><img src="https://joss.theoj.org/papers/5110170dd97fe1ebf08227881f76bda9/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/5110170dd97fe1ebf08227881f76bda9/status.svg)](https://joss.theoj.org/papers/5110170dd97fe1ebf08227881f76bda9)

Author instructions

Thanks for submitting your paper to JOSS @edejong-caltech. Currently, there isn't an JOSS editor assigned to your paper.

@edejong-caltech if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands

The text was updated successfully, but these errors were encountered:

editorialbot · 2022-05-21T16:50:44Z

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

editorialbot · 2022-05-21T16:50:46Z

Software report:

github.com/AlDanial/cloc v 1.88  T=0.30 s (1282.3 files/s, 78734.6 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                         366           2932           2331          16330
Markdown                         3            185              0           1157
YAML                            15             51             16            376
TeX                              1             39              0            282
TOML                             1              0              0              2
-------------------------------------------------------------------------------
SUM:                           386           3207           2347          18147
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

editorialbot · 2022-05-21T16:50:48Z

Wordcount for paper.md is 1913

editorialbot · 2022-05-21T16:50:48Z

Failed to discover a Statement of need section in paper

editorialbot · 2022-05-21T16:50:50Z

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1002/qj.441 is OK
- 10.1145/2833157.2833162 is OK
- 10.5194/npg-24-535-2017 is OK
- 10.5194/gmd-8-1677-2015 is OK
- 10.1175/1520-0469(1967)024<0688:CDGBC>2.0.CO;2 is OK
- 10.5194/acp-18-7313-2018 is OK
- 10.5194/gmd-10-1817-2017 is OK
- 10.21105/joss.00755 is OK
- 10.1029/2018MS001285 is OK
- 10.5194/gmd-13-5119-2020 is OK
- 10.5194/gmd-13-1335-2020 is OK
- 10.1002/2017MS000930 is OK
- 10.5194/gmd-11-3623-2018 is OK
- 10.1007/978-3-030-77964-1_2 is OK
- 10.1002/qj.1913 is OK
- 10.1029/2002JD002673 is OK
- 10.1007/s10546-020-00595-w is OK
- 10.1002/fld.1071 is OK
- 10.1029/2019MS001689 is OK
- 10.21105/joss.02807 is OK
- 10.1038/s41467-019-12982-0 is OK
- 10.1175/JAS3980 is OK
- 10.21105/joss.03219 is OK
- 10.1002/essoar.10510248.1 is OK
- 10.5194/acp-16-2083-2016 is OK
- 10.5194/gmd-13-4107-2020 is OK
- 10.1029/1999JD901161 is OK
- 10.1038/nature22806 is OK
- 10.1126/science.aad4889 is OK
- 10.5194/gmd-9-1455-2016 is OK
- 10.1175/1520-0450(1978)017<0320:ATDPIC>2.0.CO;2 is OK
- 10.1016/0307-904X(84)90088-X is OK
- 10.1017/CBO9781139165389 is OK
- 10.1039/c3fd00035d is OK

MISSING DOIs

- None

INVALID DOIs

- 10.1175/1520-0469(1949)0063C0134:TGOCDI3E2.0.CO;2 is INVALID

editorialbot · 2022-05-21T16:51:51Z

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

Kevin-Mattheus-Moerman · 2022-05-21T17:37:06Z

@edejong-caltech can you check that potentially invalid DOI ☝️ ? You can call @editorialbot check references to check them again.

edejong-caltech · 2022-05-24T01:16:42Z

@editorialbot check references

editorialbot · 2022-05-24T01:16:48Z

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1002/qj.441 is OK
- 10.1145/2833157.2833162 is OK
- 10.5194/npg-24-535-2017 is OK
- 10.5194/gmd-8-1677-2015 is OK
- 10.1175/1520-0469(1967)024<0688:CDGBC>2.0.CO;2 is OK
- 10.5194/acp-18-7313-2018 is OK
- 10.5194/gmd-10-1817-2017 is OK
- 10.21105/joss.00755 is OK
- 10.1029/2018MS001285 is OK
- 10.5194/gmd-13-5119-2020 is OK
- 10.5194/gmd-13-1335-2020 is OK
- 10.1002/2017MS000930 is OK
- 10.5194/gmd-11-3623-2018 is OK
- 10.1007/978-3-030-77964-1_2 is OK
- 10.1002/qj.1913 is OK
- 10.1029/2002JD002673 is OK
- 10.1007/s10546-020-00595-w is OK
- 10.1002/fld.1071 is OK
- 10.1029/2019MS001689 is OK
- 10.21105/joss.02807 is OK
- 10.1038/s41467-019-12982-0 is OK
- 10.1175/JAS3980 is OK
- 10.21105/joss.03219 is OK
- 10.1002/essoar.10510248.1 is OK
- 10.5194/acp-16-2083-2016 is OK
- 10.5194/gmd-13-4107-2020 is OK
- 10.1029/1999JD901161 is OK
- 10.1038/nature22806 is OK
- 10.1126/science.aad4889 is OK
- 10.5194/gmd-9-1455-2016 is OK
- 10.1175/1520-0450(1978)017<0320:ATDPIC>2.0.CO;2 is OK
- 10.1016/0307-904X(84)90088-X is OK
- 10.1017/CBO9781139165389 is OK
- 10.1039/c3fd00035d is OK

MISSING DOIs

- None

INVALID DOIs

- None

Kevin-Mattheus-Moerman · 2022-05-30T09:11:10Z

Note to handling editor, this is a second paper, after their first JOSS publication https://joss.theoj.org/papers/10.21105/joss.03219 (previous review #3219 (comment) and previous ~LOC 7548)

Kevin-Mattheus-Moerman · 2022-05-30T09:15:00Z

@dhhagan you handled the v1 of this package for the first paper. Would you be able to help edit this one? I see that you are however handling many other submissions. If you are able to handle this one, do you want me to assign you now or would you prefer if I label this as waitlisted until you are ready?

Kevin-Mattheus-Moerman · 2022-06-01T11:24:55Z

@editorialbot invite @dhhagan as editor

editorialbot · 2022-06-01T11:24:57Z

Invitation to edit this submission sent!

Kevin-Mattheus-Moerman · 2022-06-01T11:25:27Z

@dhhagan I invited you just now but let me know if you prefer if I waitlist this until you have finished handling some other submissions.

dhhagan · 2022-06-01T13:03:32Z

Hey @Kevin-Mattheus-Moerman - yea, I can handle it, though I forgot what's needed to be done to accept as an editor..?

danielskatz · 2022-06-01T13:06:43Z

You can tell editorialbot via @editorialbot assign me as editor - thanks for doing this!!

slayoo · 2022-06-01T19:29:48Z

Thank you, @dhhagan, @Kevin-Mattheus-Moerman & @danielskatz!

danielskatz · 2022-06-01T19:36:10Z

I'll go ahead and do it this time (just to reduce the list I have of unassigned papers :) ) thanks!

danielskatz · 2022-06-01T19:36:24Z

@editorialbot assign @dhhagan as editor

editorialbot · 2022-06-01T19:36:26Z

Assigned! @dhhagan is now the editor

slayoo · 2022-06-22T05:33:22Z

@dhhagan, @danielskatz, is there any input that we need to provide at this time as authors to proceed? Thanks, Sylwester

dhhagan · 2022-06-29T12:11:28Z

Hey @slayoo - I am working on finding reviewers and will post here asap.

dhhagan · 2022-06-29T12:57:31Z

👋 @darothen @josephhardinee You were the two reviewers for the original paper - do you have time/interest in reviewing the follow-up?

slayoo · 2022-07-20T22:59:33Z

if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @)

@dhhagan, let me then suggest some more names: zzheng93, mdpetters, maul1609, smturbev, emmasimp

slayoo · 2022-07-28T09:07:50Z

@dhhagan, @danielskatz, let us kindly ask for the status of this pre-review, thanks.

dhhagan · 2022-08-10T17:20:44Z

Hey @slayoo so sorry about the delay - got lost in my GitHub notifications. I will get to this within the next hour.

claresinger · 2022-11-18T23:04:32Z

@editorialbot add @emmasimp as reviewer

editorialbot · 2022-11-18T23:04:33Z

I'm sorry @claresinger, I'm afraid I can't do that. That's something only editors are allowed to do.

claresinger · 2022-11-21T16:27:37Z

@editorialbot invite @emmasimp as reviewer

@dhhagan Please try this again, the command didn't work. You need to add not invite.

dhhagan · 2022-11-25T15:39:10Z

@editorialbot add @claresinger as reviewer

editorialbot · 2022-11-25T15:39:12Z

@claresinger added to the reviewers list!

dhhagan · 2022-11-25T15:39:28Z

@editorialbot add @douglowe as reviewer

editorialbot · 2022-11-25T15:39:30Z

@douglowe added to the reviewers list!

dhhagan · 2022-11-25T15:40:05Z

@editorialbot start review

editorialbot · 2022-11-25T15:40:08Z

OK, I've started the review over in #4968.

slayoo · 2022-11-25T15:46:25Z

@dhhagan

@editorialbot add @claresinger as reviewer

Clare is an author here, not a reviewer.
The intended command likely was: @editorialbot add @emmasimp as reviewer

claresinger · 2022-11-26T19:39:32Z

@dhhagan Please remove me as a reviewer. I am an author on this paper.

claresinger · 2022-11-29T01:34:43Z

@Kevin-Mattheus-Moerman @danielskatz @dhhagan
Please remove me as a reviewer of this paper. I am one of the authors. I think you probably meant to add @emmasimp instead.

Kevin-Mattheus-Moerman · 2022-12-01T21:23:39Z

@editorialbot remove @claresinger as reviewer

editorialbot · 2022-12-01T21:23:41Z

@claresinger removed from the reviewers list!

Kevin-Mattheus-Moerman · 2022-12-01T21:26:04Z

@editorialbot add @emmasimp as reviewer

editorialbot · 2022-12-01T21:26:05Z

@emmasimp added to the reviewers list!

claresinger · 2022-12-01T21:27:36Z

Thank you @Kevin-Mattheus-Moerman 🙏

slayoo · 2023-02-07T09:29:51Z

@editorialbot generate pdf

editorialbot · 2023-02-07T09:31:33Z

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

slayoo · 2023-02-13T16:04:52Z

@editorialbot generate pdf

editorialbot · 2023-02-13T16:06:50Z

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

slayoo · 2023-02-13T16:11:22Z

@editorialbot generate pdf

editorialbot · 2023-02-13T16:12:39Z

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

slayoo · 2023-02-13T16:15:58Z

@editorialbot generate pdf

editorialbot · 2023-02-13T16:17:27Z

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

douglowe · 2023-02-13T16:22:02Z

Does the article proof need regenerating in the review thread rather than here? #4968

slayoo · 2023-02-13T16:22:38Z

indeed! thanks @douglowe

editorialbot added the pre-review label May 21, 2022

editorialbot added Python TeX labels May 21, 2022

editorialbot assigned dhhagan Jun 1, 2022

editorialbot assigned claresinger Nov 25, 2022

editorialbot closed this as completed Nov 25, 2022

editorialbot unassigned claresinger Dec 1, 2022

[PRE REVIEW]: New developments in PySDM and PySDM-examples v2: collisional breakup, immersion freezing, dry aerosol composition initialisation, and adaptive time-stepping #4412

[PRE REVIEW]: New developments in PySDM and PySDM-examples v2: collisional breakup, immersion freezing, dry aerosol composition initialisation, and adaptive time-stepping #4412

Comments

editorialbot commented May 21, 2022 • edited

Status

editorialbot commented May 21, 2022

editorialbot commented May 21, 2022

editorialbot commented May 21, 2022

editorialbot commented May 21, 2022

editorialbot commented May 21, 2022

editorialbot commented May 21, 2022

Kevin-Mattheus-Moerman commented May 21, 2022

edejong-caltech commented May 24, 2022

editorialbot commented May 24, 2022

Kevin-Mattheus-Moerman commented May 30, 2022 • edited

Kevin-Mattheus-Moerman commented May 30, 2022

Kevin-Mattheus-Moerman commented Jun 1, 2022

editorialbot commented Jun 1, 2022

Kevin-Mattheus-Moerman commented Jun 1, 2022

dhhagan commented Jun 1, 2022

danielskatz commented Jun 1, 2022

slayoo commented Jun 1, 2022

danielskatz commented Jun 1, 2022

danielskatz commented Jun 1, 2022

editorialbot commented Jun 1, 2022

slayoo commented Jun 22, 2022

dhhagan commented Jun 29, 2022

dhhagan commented Jun 29, 2022

slayoo commented Jul 20, 2022

slayoo commented Jul 28, 2022

dhhagan commented Aug 10, 2022

claresinger commented Nov 18, 2022

editorialbot commented Nov 18, 2022

claresinger commented Nov 21, 2022

dhhagan commented Nov 25, 2022

editorialbot commented Nov 25, 2022

dhhagan commented Nov 25, 2022

editorialbot commented Nov 25, 2022

dhhagan commented Nov 25, 2022

editorialbot commented Nov 25, 2022

slayoo commented Nov 25, 2022

claresinger commented Nov 26, 2022

claresinger commented Nov 29, 2022

Kevin-Mattheus-Moerman commented Dec 1, 2022

editorialbot commented Dec 1, 2022

Kevin-Mattheus-Moerman commented Dec 1, 2022

editorialbot commented Dec 1, 2022

claresinger commented Dec 1, 2022

slayoo commented Feb 7, 2023

editorialbot commented Feb 7, 2023

slayoo commented Feb 13, 2023

editorialbot commented Feb 13, 2023

slayoo commented Feb 13, 2023

editorialbot commented Feb 13, 2023

slayoo commented Feb 13, 2023

editorialbot commented Feb 13, 2023

douglowe commented Feb 13, 2023

slayoo commented Feb 13, 2023

editorialbot commented May 21, 2022 •

edited

Kevin-Mattheus-Moerman commented May 30, 2022 •

edited