-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: Spafe: Simplified python audio features extraction #4739
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Wordcount for |
|
👋🏼 @SuperKogito, @hadware, @hbredin this is the review thread for the paper. All of our communications will happen here from now on. As a reviewer, the first step is to create a checklist for your review by entering
as the top of a new comment in this thread. These checklists contain the JOSS requirements. As you go over the submission, please check any items that you feel have been satisfied. The first comment in this thread also contains links to the JOSS reviewer guidelines. The JOSS review is different from most other journals. Our goal is to work with the authors to help them meet our criteria instead of merely passing judgment on the submission. As such, the reviewers are encouraged to submit issues and pull requests on the software repository. When doing so, please mention #4739 so that a link is created to this thread (and I can keep an eye on what is happening). Please also feel free to comment and ask questions on this thread. In my experience, it is better to post comments/questions/suggestions as you come across them instead of waiting until you've reviewed the entire package. We aim for reviews to be completed within about 2-4 weeks. Please let me know if any of you require some more time. We can also use EditorialBot (our bot) to set automatic reminders if you know you'll be away for a known period of time. Please feel free to ping me (@faroit) if you have any questions/concerns. |
Review checklist for @hadwareConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
As mentioned here, I cannot start working on this review before the end of September. I apologize if my initial statement was not clear enough... |
@hbredin yes, Sorry i forgot your schedule. No worries. That's all fine. Thanks a lot again |
I started reading the code and the paper, but I'm currently on holidays. I'll start giving some feedback in the first week of october as well. |
Review checklist for @hbredinConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@SuperKogito please update us on the status of the submission with respect to the two issues opened in spafe above. Tell us if you need more time. |
@faroit I apologize to you and to the two reviewers for my radio silence in the last couple of weeks. Unfortunately, I have been very busy and couldn't find time to provide meaningful responses to the opened issues (which I appreciate). I intend to address these issues and the PR thoroughly at the latest this weekend. Thank you for understanding and being patient <3 . |
@SuperKogito can you update us on the submission status? Let us know if you need more time or if we should pause the review |
Hello @faroit, |
@SuperKogito Thanks for the update! 👍 |
@hadware @SuperKogito can you update us on the status of SuperKogito/spafe#46? |
@hbredin can you update us on the status of your review? Is there still a blocking issue? |
Unfortunately, @hadware seems to be very busy and I am still waiting for his review / merge of my latest chances. |
Done! Archive is now 0.5281/zenodo.7533946 |
@editorialbot set v0.3.1 as version |
Done! version is now v0.3.1 |
@editorialbot recommend-accept |
|
|
👋 @openjournals/sbcs-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#3872, then you can now move forward with accepting the submission by compiling again with the command |
@faroit isn't the DOI missing the first digit? it is supposed to be |
@editorialbot set 10.5281/zenodo.7533946 as archive |
Done! Archive is now 10.5281/zenodo.7533946 |
@editorialbot generate pdf |
@editorialbot recommend-accept |
|
|
@editorialbot generate pdf |
👋 @openjournals/sbcs-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#3907, then you can now move forward with accepting the submission by compiling again with the command |
@editorialbot accept |
|
🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦 |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Sorry for being delayed, I am ill. Congratulations! 🥳 |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @SuperKogito (Ayoub Malek)
Repository: https://github.com/SuperKogito/spafe
Branch with paper.md (empty if default branch):
Version: v0.3.1
Editor: @faroit
Reviewers: @hadware, @hbredin
Archive: 10.5281/zenodo.7533946
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@hadware & @hbredin, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @faroit know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @hadware
📝 Checklist for @hbredin
The text was updated successfully, but these errors were encountered: