Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: PYroMat: A Python package for thermodynamic properties #4743

Closed
editorialbot opened this issue Sep 7, 2022 · 30 comments
Closed
Assignees

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Sep 7, 2022

Submitting author: @jranalli (Joseph Ranalli)
Repository: https://github.com/chmarti1/PYroMat
Branch with paper.md (empty if default branch): joss2022
Version: 2.2.1
Editor: @jgostick
Reviewers: @espottesmith, @fwitte
Managing EiC: Kristen Thyng

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/42d6ea5759b5467dad54709db33ea03d"><img src="https://joss.theoj.org/papers/42d6ea5759b5467dad54709db33ea03d/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/42d6ea5759b5467dad54709db33ea03d/status.svg)](https://joss.theoj.org/papers/42d6ea5759b5467dad54709db33ea03d)

Author instructions

Thanks for submitting your paper to JOSS @jranalli. Currently, there isn't a JOSS editor assigned to your paper.

@jranalli if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 3 (PE) Physics and Engineering labels Sep 7, 2022
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Checking the BibTeX entries failed with the following error:

No paper file path

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.88  T=0.29 s (172.1 files/s, 72410.0 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          22           2511           6128           7678
HTML                            13            160              0           2804
TeX                              8            257              5            933
Markdown                         3             62              0            257
CSS                              1             25              5            150
XML                              1              2              0             35
YAML                             1              1              4             18
Bourne Shell                     1              3              1              4
-------------------------------------------------------------------------------
SUM:                            50           3021           6143          11879
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Failed to discover a Statement of need section in paper

@editorialbot
Copy link
Collaborator Author

⚠️ An error happened when generating the pdf. Paper file not found.

@kthyng
Copy link

kthyng commented Sep 7, 2022

@editorialbot set joss2022 as branch

@editorialbot
Copy link
Collaborator Author

Done! branch is now joss2022

@kthyng
Copy link

kthyng commented Sep 7, 2022

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

⚠️ An error happened when generating the pdf. Paper file not found.

@kthyng
Copy link

kthyng commented Sep 7, 2022

Hi @jranalli! The paper file in your joss2022 branch needs to be needs "paper.md" for the bot to find it.

@jranalli
Copy link

jranalli commented Sep 7, 2022

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

@jranalli
Copy link

jranalli commented Sep 7, 2022

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@jranalli
Copy link

jranalli commented Sep 7, 2022

In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission

From their area descriptions, I identified a few potential matches in no particular order: ronshnapp, mefuller, zadehsey, erasmuss, espottesmith, fwitte, mwerwee

@kthyng
Copy link

kthyng commented Sep 9, 2022

@jgostick What do you think about editing this submission? (Very different than the last request!)

@kthyng
Copy link

kthyng commented Sep 9, 2022

@editorialbot invite @jgostick as editor

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@jgostick
Copy link

This one is my jam! I will almost certainly use this in my work.

@editorialbot assign @jgostick as editor

@jgostick
Copy link

@editorialbot assign @jgostick as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @jgostick is now the editor

@kthyng
Copy link

kthyng commented Sep 12, 2022

@jgostick Awesome! It's hard to know what is the best fit from this end of things :)

@jgostick
Copy link

@editorialbot add @espottesmith as reviewer

@editorialbot
Copy link
Collaborator Author

@espottesmith added to the reviewers list!

@jgostick
Copy link

@editorialbot add @fwitte as reviewer

@editorialbot
Copy link
Collaborator Author

@fwitte added to the reviewers list!

@jgostick
Copy link

@editorialbot begin review

@editorialbot
Copy link
Collaborator Author

I'm sorry human, I don't understand that. You can see what commands I support by typing:

@editorialbot commands

@jgostick
Copy link

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #4757.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants