Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: lpjmlkit: A toolkit for operating LPJmL and model-specific data processing #5314

Closed
editorialbot opened this issue Mar 30, 2023 · 38 comments
Assignees

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Mar 30, 2023

Submitting author: @jnnsbrr (Jannes Breier)
Repository: https://github.com/PIK-LPJmL/lpjmlkit
Branch with paper.md (empty if default branch): JOSS
Version: v.1.0.13
Editor: @graciellehigino
Reviewers: @egouldo, @tonyewong
Managing EiC: Kristen Thyng

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/19419cb26456cff5450b6e3de0f90d11"><img src="https://joss.theoj.org/papers/19419cb26456cff5450b6e3de0f90d11/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/19419cb26456cff5450b6e3de0f90d11/status.svg)](https://joss.theoj.org/papers/19419cb26456cff5450b6e3de0f90d11)

Author instructions

Thanks for submitting your paper to JOSS @jnnsbrr. Currently, there isn't a JOSS editor assigned to your paper.

@jnnsbrr if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 6 (ESE) Earth Sciences and Ecology labels Mar 30, 2023
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.88  T=0.08 s (1020.8 files/s, 194732.9 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
R                               57           1328           3314           7002
Markdown                         5            178              0            881
JavaScript                       2             21             38            502
JSON                             7              0              0            448
TeX                              1             16              0            251
YAML                             4             19             10            151
Rmd                              2            137            606            123
make                             1             11              7             27
-------------------------------------------------------------------------------
SUM:                            79           1710           3975           9385
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 1839

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.5194/gmd-12-5029-2019 is OK
- 10.1038/s41893-019-0465-1 is OK
- 10.1016/j.jhydrol.2003.09.029 is OK
- 10.1016/j.envsoft.2018.09.004 is OK
- 10.1111/j.1365-2486.2006.01305.x is OK
- 10.5194/gmd-11-429-2018 is OK
- 10.5194/gmd-11-2789-2018 is OK
- 10.5194/gmd-12-1299-2019 is OK
- 10.5194/gmd-12-2419-2019 is OK
- 10.5194/bg-19-957-2022 is OK
- 10.5194/esd-12-1037-2021 is OK
- 10.1371/journal.pbio.1001745 is OK
- 10.1046/j.1365-2486.2003.00569.x is OK
- 10.1038/s41597-022-01710-x is OK
- 10.5194/gmd-11-1343-2018 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@kthyng
Copy link

kthyng commented Mar 30, 2023

Hi @jnnsbrr and thanks for your submission. Can you add a sentence or two to the beginning of the paper to explain more about dynamic global vegetative models and where they fit in with other models? There are a lot of acronyms and not a lot of explanation for context. Also is it normal to have to install R packages to see any docs?

@jnnsbrr
Copy link

jnnsbrr commented Mar 31, 2023

Dear @kthyng,
thank you! I added a definition for DGVMs to the Statement of need section (update is on the way).
Yes, its normal to first install R packages to be able to view the rendered rd files (in ./man) in R.
For our R package we additionally provide the full documentation at CRAN and at r-universe. Both are linked in the paper, CRAN publication in the Summary and r-universe documentation in the Documentation & License section.

@kthyng
Copy link

kthyng commented Mar 31, 2023

Hi @martinfleis! Are you interested in editing this submission? I know it's a bit outside your field!

@kthyng
Copy link

kthyng commented Mar 31, 2023

@editorialbot invite @martinfleis as editor

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@martinfleis
Copy link

@kthyng sorry! A got no clue what this is doing, so would rather let someone else to take care of it.

@kthyng
Copy link

kthyng commented Apr 11, 2023

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@kthyng
Copy link

kthyng commented Apr 11, 2023

Hi @fraukewiese! Might you be able to edit this submission?

@kthyng
Copy link

kthyng commented Apr 11, 2023

@editorialbot invite @fraukewiese as editor

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@fraukewiese
Copy link

Thanks for the invitation. Unfortunately, I cannot edit this submission due to time constraints but also lack of understanding of the content of the software.

@kthyng
Copy link

kthyng commented Apr 12, 2023

Hi @jnnsbrr — What sort of expertise would overlap with the topic of your software? We seem to be having some trouble finding a good fit.

@jnnsbrr
Copy link

jnnsbrr commented Apr 12, 2023

Hi @kthyng,
thank you!
I think the following topics would be relevant ...

  1. background in R
  2. numerical modelling AND/OR process-based modelling AND/OR (global) ecological modelling
  3. - and only nice to have - expertise with Earth System Models OR Dynamic Global Vegetation Models

Starting from the bottom of this list of possible reviewers from the top and judging by the their preferred programming languages as well as topics/domains it could be (github username):

  • dm807cam
  • egouldo
  • skiptoniam
  • tonyewong
  • mhesselbarth
  • jmp75
  • stephendavidgregory
  • abigailsnyder
  • vwmaus
  • trashbirdecology
  • khaors
  • alessandroamaranto
  • MoLi7
  • stephendavidgregory

@kthyng
Copy link

kthyng commented Apr 18, 2023

@jnnsbrr ok thank you! That gave me a person to try who is available...

@kthyng
Copy link

kthyng commented Apr 18, 2023

@graciellehigino are you up for editing this paper?

@kthyng
Copy link

kthyng commented Apr 18, 2023

@editorialbot invite @graciellehigino as editor

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@jnnsbrr
Copy link

jnnsbrr commented Apr 18, 2023

Thank you!
An alternative could also be to ask one of the authors of the rlpjguess R package (mauriziobagnara, Rasilgon, florianhartig), which is a similar approach for a sister model of LPJmL (LPJGUESS) and was published in Environmental Modelling & Software.

@graciellehigino
Copy link

@editorialbot assign @graciellehigino as editor

Imma give it a go! Let's get this paper reviewed! [=

@editorialbot
Copy link
Collaborator Author

Assigned! @graciellehigino is now the editor

@jnnsbrr
Copy link

jnnsbrr commented Apr 19, 2023

Cool, thank you 🙂

@kthyng
Copy link

kthyng commented Apr 19, 2023

@jnnsbrr We have a pool of editors for JOSS from which we need to choose, but for reviewers we can pick essentially anyone who can/will do the job and doesn't have a conflict of interest! Your reviewer suggestions will be very helpful for @graciellehigino in choosing reviewers.

@openjournals openjournals deleted a comment from editorialbot Apr 21, 2023
@graciellehigino
Copy link

@editorialbot add @egouldo as reviewer

@editorialbot
Copy link
Collaborator Author

@egouldo added to the reviewers list!

@graciellehigino
Copy link

@editorialbot add @tonyewong as reviewer

1 similar comment
@graciellehigino
Copy link

@editorialbot add @tonyewong as reviewer

@editorialbot
Copy link
Collaborator Author

@tonyewong added to the reviewers list!

@graciellehigino
Copy link

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #5447.

@arfon
Copy link
Member

arfon commented Jun 23, 2024

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

MLJ: A Julia package for composable machine learning
Submitting author: @ablaom
Handling editor: @terrytangyuan (Retired)
Reviewers: @degleris1, @henrykironde
Similarity score: 0.8287

The drake R package: a pipeline toolkit for reproducibility and high-performance computing
Submitting author: @wlandau
Handling editor: @arfon (Active)
Reviewers: @arfon
Similarity score: 0.8181

mikropml: User-Friendly R Package for Supervised Machine Learning Pipelines
Submitting author: @pschloss
Handling editor: @arfon (Active)
Reviewers: @JonnyTran, @FedericoComoglio
Similarity score: 0.8180

eixport: An R package to export emissions to atmospheric models
Submitting author: @ibarraespinosa
Handling editor: @leeper (Retired)
Reviewers: @jhollist
Similarity score: 0.8111

mlr3: A modern object-oriented machine learning framework in R
Submitting author: @mllg
Handling editor: @terrytangyuan (Retired)
Reviewers: @nhejazi, @osorensen
Similarity score: 0.8084

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants